[development] coding standard question

Peter Wolanin pwolanin at gmail.com
Mon Aug 27 21:33:11 UTC 2007


Apparently this document is in CVS, and needs someone on d.o to run CVS update.

I just made the suggested change:

Index: CODING_STANDARDS.html
===================================================================
RCS file: /cvs/drupal-contrib/contributions/CODING_STANDARDS.html,v
retrieving revision 1.8
diff -u -p -r1.8 CODING_STANDARDS.html
--- CODING_STANDARDS.html       6 Aug 2007 12:04:11 -0000       1.8
+++ CODING_STANDARDS.html       27 Aug 2007 21:29:53 -0000
@@ -1,3 +1,4 @@
+<!-- $Id$ -->
   <p><em>Note: The Drupal Coding Standards applies to code that is
   to become a part of Drupal. This document is based on the
   <a href="http://pear.php.net/manual/en/standards.php">PEAR Coding
@@ -258,8 +259,9 @@ $this-&gt;_status
   <h3>Constants</h3>

   <p>Constants should always be all-uppercase, with underscores to
-  separate words. Prefix constant names with the uppercased name of
-  the module they are a part of.</p>
+  separate words. This includes pre-defined PHP constants like
+  TRUE, FALSE, and NULL. Prefix module-defined constant names with
+  the uppercased name of the module they are a part of.</p>

   <h3>Global Variables</h3>


On 8/27/07, Nedjo Rogers <nedjo at islandnet.com> wrote:
> The documented standard is to use upper case for all constants, see the
> Constants section at:
>
> http://drupal.org/coding-standards
>
> Maybe we should add something like "This includes pre-defined PHP constants
> like TRUE, FALSE, and NULL."
>
> A year ago we cleaned up these constants in core,
> http://drupal.org/node/72204, but since then lower case instances have crept
> back in.
>
>


More information about the development mailing list