[development] patches that need reviews/work

Ashraf Amayreh mistknight at gmail.com
Fri Jun 1 14:40:52 UTC 2007


Centralizing everything that needs to be done in the next month in one
thread is much better and focused than going through hundreds of previous
emails just to find that patch that you were interested in at one time or
the other. The emails on the list that talked about patch reviews are
currently scattered through hundreds of development emails, it's ridiculous
to have to go through all of that.

Sorry I forgot to include a description of my patch, it's mainly a patch
that wraps the administration content retrieval query in db_rewrite_sql to
allow external modules to alter it.

On 6/1/07, Gabor Hojtsy <gabor at hojtsy.hu> wrote:
>
> Ashraf Amayreh wrote:
> > Thanks to Dries' wise decision, we can now really put some extra efforts
> > to make this a perfect release, there are patches that need reviews,
> > others that need some work to minimize their performance impact, and
> > others that are RTBC but are still not.
> >
> > To ease this and make it more effective, everyone who has a patch that
> > needs reviews, some work or is RTBC but is still not, please post it in
> > this thread to get it under lights. Please don't post another
> > developer's patches unless you're in sync with him so that this won't
> > get filled with repetitive posts. A short description of each patch and
> > what it does should be helpful as long as it's no longer than a
> > paragraph, this is a second reason the patch author is in a better
> > position to post here rather than someone else, interested parties can
> > see the details in the issue page. By doing this, we can centralize all
> > our efforts on the patches in this thread.
> >
> > Finally, let's avoid giving opinions on these patches over here to
> > streamline this thread and attempt to make it as direct as possible. The
> > issue page can be used for that.
> >
> > My patch is a simple one that Moshe has agreed is RTBC, so I hope we can
> > get it in and turn to other important patches.
> >
> > http://drupal.org/node/114938
>
> Some advice:
>   - next time try to follow your own suggestion and explain what your
> patch does when trying to shed some light on it!
>   - for the same reason, having such patches in a generic titled thread
> can quickly go out of focus as far as I see...
>
> Gabor
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.drupal.org/pipermail/development/attachments/20070601/1c3e2ef0/attachment.htm 


More information about the development mailing list