[development] What about reviewing patches?

Earnie Boyd earnie at users.sourceforge.net
Thu Aug 14 12:53:58 UTC 2008

Quoting Zohar Stolar <z.stolar at gmail.com>:

> Angela Byron wrote:
>> Marcel Partap wrote:
>>> Mhh.. what about (auto-)committing to a D7.x-next branch after two 
>>> independent people have confirmed a patch as working?
>> Dear sweet Lord, NO! :)
> It does'nt have to be auto-committed, but if 2-3 persons have 
> reviewed and marked RTBC, the status can escalate into something like 
> TRTBC (Thoroughly RTBC).
> This may have a nice effect on both the committers, as they will be 
> more focused, and on the rest of us, since the more we review, the 
> faster things will probably be committed.

Won't help.  We have a large funnel and the end of the funnel is a 
committer.  There is no way for the committer to catch up with all 
commits.  We need more committers to resolve that issue.

It'd be interesting and bazaar to see another repository of Drupal core 
where all CVS account holders could commit patches after review.  I 
wonder just how broken its HEAD would be.
  Earnie -- http://for-my-kids.com/
-- http://give-me-an-offer.com/

More information about the development mailing list