[development] Trust (was: Hit and run contrib)

Earl Miles merlin at logrus.com
Sun Jun 1 06:33:01 UTC 2008

Jakob Petsovits wrote:
> On Sunday, 1. June 2008, Jakob Petsovits wrote:
>> On Saturday, 31. May 2008, Earl Miles wrote:
>>> I just grepped and looked at 43 instances of switch() in Views 1.
>>> I find one case that might look like a missing break in the theme
>>> wizard; and it's kind of odd. Otherwise, nada. Waste of my time.
>> Views 2. Ok, let me see if I can dig this up again... don't know anymore
>> where I found it, but perhaps it's still in there somewhere.
> Ok, found it, and it seems that it's indeed intended
> (for reference, 'style_options' vs. 'row_options').
> So shame on me and further reinforcing the notion that I should not
> be granted commit access to Views.
> Putting a
> // fall through
> comment instead of the
> break;
> might help avoiding stupid monkeys like me, though.
> Sorry for wasting your time; friends?,

Hehe. No prob. =)

More information about the development mailing list