[development] the time of $op is over?

Bryan Ollendyke bto108 at psu.edu
Fri May 9 12:50:22 UTC 2008


+1 del $op.  Couldn't this also lead to some deeper integration with
actions/triggers and allow people to write their own $op states as
functions?

Regardless I think it's a logical progression instead of everyone writing a
switch statement to parse out which $op it is everytime.

On Fri, May 9, 2008 at 8:35 AM, Moshe Weitzman <weitzman at tejasa.com> wrote:

> I agree that we should move away from op to dedicated hooks. for
> example, hook_nodeapi_delete().
>
> Hook_help can be should be shot and killed by advanced_help module.
>
> On Fri, May 9, 2008 at 5:23 AM, Gábor Hojtsy <gabor at hojtsy.hu> wrote:
> > Hello,
> >
> >  Now that the registry patch landed, it looks like the time of $op
> >  might be over. General hooks implementing different branches with $op
> >  will always be loaded regardless of the exact need for them. Larry
> >  already suggests using the more granular *_preprocess_hookname() type
> >  of callbacks instead of the generic *_preprocess() callbacks for theme
> >  stuff, so that only those needed will be loaded. Take nodeapi for
> >  example. Code for loading nodes might often be needed, but not code
> >  for updating or deleting them, right? Those could easily be admin.inc
> >  stuff.
> >
> >  So what do you think about $op? Should we evaluate on a case-by-case
> >  basis to make function level callbacks out of $op's or just do it
> >  wholesale (no, I am not volunteering for a patch) to get an overall
> >  consistent API.
> >
> >  Gabor
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.drupal.org/pipermail/development/attachments/20080509/6dbc45ef/attachment.htm 


More information about the development mailing list