[development] Please stop using git diff --no-prefix. -p1 patches are now the standard
yahgrp at poplarware.com
Thu Apr 14 21:35:27 UTC 2011
Actually, I think the documentation issues for Git are now being
managed in the Documentation project issue queue, with tag "git".
And there is already an issue to merge the previous stuff in the
patching section into the Git docs. It's in the Documentation project.
On 04/14/2011 01:34 PM, Randy Fay wrote:
> Thanks for catching that. I really think we should just get those
> instructions out of there.
> To fix git documentation, please file issues at
> On Thu, Apr 14, 2011 at 2:04 PM, Guillaume<guillaume at resist.ca> wrote:
>> This doc needs to be fixed then:
>> It says to use:
>> diff -up path/to/file/example.module path/to/file/exampleNew.module>
>> Which produces p0 patches :(.
>> On 04/11/2011 01:21 PM, Randy Fay wrote:
>>> I noticed in another thread that somebody suggested git diff --no-prefix
>>> for creating patches.
>>> Please don't do that any more. We've moved to standard git patches (git
>>> diff without the --no-prefix, meaning a patch -p1 patch).
>>> Testbot support for -p0 patches (--no-prefix) will be removed around the
>>> end of May. See http://groups.drupal.org/node/140204
>>> Some of you may have the --no-prefix stuff in your .gitconfig. Please
>>> remove it from there as well.
>>> In the issue queues, please start to insist on rerolls for -p0 formatted
>>> patches (if they have no a/ and b/ in front of the filenames.
>>> Thanks for your cooperation.
>>> Randy Fay
>>> Drupal Module and Site Development
>>> randy at randyfay.com<mailto:randy at randyfay.com>
>>> +1 970.462.7450
Jennifer Hodgdon * Poplar ProductivityWare
Drupal web sites and custom Drupal modules
More information about the development