[documentation] [task] Update node_example.module to use revisions

[drewish]

Issue status update for 
http://drupal.org/node/50626
Post a follow up: 
http://drupal.org/project/comments/add/50626

 Project:      Documentation
 Version:      <none>
 Component:    Developer Guide
 Category:     tasks
 Priority:     normal
 Assigned to:  drewish
 Reported by:  drewish
 Updated by:   drewish
-Status:       patch (code needs review)
+Status:       fixed

i'm going to go ahead an commit this.




drewish



Previous comments:
------------------------------------------------------------------------

Tue, 21 Feb 2006 22:52:10 +0000 : drewish

Attachment: http://drupal.org/files/issues/node_example.module_revisions.patch (3.54 KB)

I was looking information on the revision system when I came across a
comment [1] from someone confused by the changes. In there they asked
for node_example.module to be updated to demonstrate revisions.
Thinking that was a good idea I started on it. 


In the process I realized that it was kind of kludgy that you had to
implement hook_nodeapi() to delete revisions. I'm working on a patch
for that so I'm putting this aside for the moment. 


Attached is a patch that adds revision support EXCEPT for deleting a
single revision.
[1] http://drupal.org/node/30030#comment-94901




------------------------------------------------------------------------

Tue, 21 Feb 2006 23:06:30 +0000 : drewish

i've opened an issue to add a hook_delete_revision():
http://drupal.org/node/50627




------------------------------------------------------------------------

Wed, 22 Feb 2006 23:59:55 +0000 : drewish

Attachment: http://drupal.org/files/issues/node_example.module_revisions_0.patch (5.75 KB)

i finished up the patch, adding an implementation of
hook_nodeapi(op=delete revision). please review the changes.




------------------------------------------------------------------------

Thu, 23 Feb 2006 00:44:38 +0000 : drewish

Attachment: http://drupal.org/files/issues/node_example.module_revisions_1.patch (5.79 KB)

on irc, killes suggested that nid be indexed. rather than provide
separate mysql/pgsql schemas i've just made vid, nid a joint primary
key. 


i should also mention, i've upated quite a bit of other code in the
module to follow the current practices in core (with the exception of
the long forms format). like, removing the hook_link implementation as
it's handled by tabs now.