[documentation] [Documentation bug] hook_link isn't just for links

[bdragon]

Issue status update for 
http://drupal.org/node/107148
Post a follow up: 
http://drupal.org/project/comments/add/107148

 Project:      Documentation
 Version:      <none>
 Component:    Documentation in CVS
 Category:     bug reports
 Priority:     minor
 Assigned to:  bdragon
 Reported by:  bdragon
 Updated by:   bdragon
-Status:       patch (code needs review)
+Status:       fixed

Going once, going twice, SOLD!




bdragon



Previous comments:
------------------------------------------------------------------------

Fri, 05 Jan 2007 19:05:49 +0000 : bdragon

Attachment: http://drupal.org/files/issues/hook_link_clarification.patch (2.17 KB)

The documentation on hook_link doesn't mention that having a title
without an href will be themed without running through a l() call. This
is a useful fact to know, and is contrary to the current documentation.




------------------------------------------------------------------------

Fri, 05 Jan 2007 19:14:04 +0000 : fax8

+1 Original documentation is really confused and incorrect.


Fabio Varesano




------------------------------------------------------------------------

Fri, 05 Jan 2007 19:33:33 +0000 : Caleb G

For us following along at home - why is this useful to know? (example?)




------------------------------------------------------------------------

Fri, 05 Jan 2007 19:51:10 +0000 : bdragon

People porting custom 4.7 modules that used non-link links to show
summary statistics and such.


*slaps forehead*
Doh! Forgot to provide an example....




------------------------------------------------------------------------

Fri, 05 Jan 2007 19:51:35 +0000 : fax8

my video module add video size and lenght to links in 4.7
(example: http://www.windsmpeg.tk/video+type/full+video)
they are only simple text and reading hook_link original
documentation I was not able to understand that I can also add simple
text.




------------------------------------------------------------------------

Fri, 05 Jan 2007 20:23:55 +0000 : bdragon

C'mon man, leave the status alone for a few minutes ;). I'll CNR it when
I have the updated patch ready . ;)


I'm using your example for the code section, btw.




------------------------------------------------------------------------

Fri, 05 Jan 2007 20:54:33 +0000 : bdragon

Attachment: http://drupal.org/files/issues/hook_link_clarification_0.patch (2.63 KB)

Ok, this one has an example too...




------------------------------------------------------------------------

Fri, 05 Jan 2007 21:11:09 +0000 : RobRoy

I'd change and to &&. Besides that looks pretty good.




------------------------------------------------------------------------

Fri, 05 Jan 2007 21:36:25 +0000 : bdragon

Attachment: http://drupal.org/files/issues/hook_link_clarification_1.patch (2.62 KB)

Whoops, agree there, && is the way to go there... Shoulda read it better
when copy/pasting.