Issue status update for http://drupal.org/node/19611 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: Junyor Reported by: Junyor Updated by: Junyor Status: patch @Gordon: They already are separate toolkits. There's *no* GD 1 processing in core at all. This patch separates all the GD 2 specific functions from the general toolkit handling functions. The GD 1 toolkit attached here was provided by Stefan. Junyor Previous comments: ------------------------------------------------------------------------ March 28, 2005 - 22:46 : Junyor Attachment: http://drupal.org/files/issues/system-image.patch (6.8 KB) The new image handling tools in core have a lot of GD2-specific logic, making image.inc overly cluttered and complicated. If gd2 were just treated like another toolkit (though the only one included by default), then the image.inc code would be much cleaner and more easily maintained. This patch removes all the GD2 stuff from image.inc and puts it into image.gd2.inc. The _settings hook is now doing what it sounds like it should, return settings for the toolkit. I've added a _check hook which will tell if the PHP functions needed are available. If _check fails, then the toolkit will not be listed on admin > settings and an error will be logged in watchdog. I've also update image.gd1.inc, image.imlib.inc, and image.imagick.inc with the same logic. ------------------------------------------------------------------------ March 28, 2005 - 23:08 : Junyor Attachment: http://drupal.org/files/issues/image.gd2.inc (3.07 KB) ------------------------------------------------------------------------ March 28, 2005 - 23:09 : Junyor Attachment: http://drupal.org/files/issues/image.gd1_0.inc (1.8 KB) ------------------------------------------------------------------------ March 28, 2005 - 23:09 : Junyor Attachment: http://drupal.org/files/issues/image.imagick.inc (2.19 KB) ------------------------------------------------------------------------ March 28, 2005 - 23:10 : Junyor Attachment: http://drupal.org/files/issues/image.imlib.inc (2.07 KB) ------------------------------------------------------------------------ March 29, 2005 - 00:44 : gordon I am not too sure if the gd tool kit should be split into 2 tool kits. Now I am only speaking from a debian pov, but the php4-gd package is linked against gd2. Also from a Drupal POV, the difference between gd1 and gd2 are so minor that having them as they have always been, as effectively 1 tool kit has alway made sence from a maintenance POV. Also the standard php extension is just called gd. -1 on dividing gd1 and gd2 into separate tool kits.