Issue status update for http://drupal.org/node/23211 Project: Drupal Version: cvs Component: base system Category: tasks Priority: minor Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch it should not be 1048576 since $size</code would have already been divided by 1024 once at that point. If that <code>if were an else if then you would have been correct. drumm Previous comments: ------------------------------------------------------------------------ May 19, 2005 - 13:56 : drumm Attachment: http://drupal.org/files/issues/common.inc_3.diff (662 bytes) format_size(1024) currently returns "1024 bytes" when it would be a bit nicer to say "1 KB". ------------------------------------------------------------------------ May 19, 2005 - 14:29 : Bèr Kessels I could be wrong, but there are two checks for $size >= 1024 shouldnt the last one check for $size >= 1048576 ?