Project: Drupal Version: cvs Component: user.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: Dries Status: patch BTW, it looks like you switched 'Rule type' and 'Access type' in the overview table. Dries Previous comments: ------------------------------------------------------------------------ January 25, 2005 - 21:06 : drumm Attachment: http://drupal.org/files/issues/screenshot.png (9.7 KB) Here is a screenshot. ------------------------------------------------------------------------ January 25, 2005 - 21:14 : drumm Attachment: http://drupal.org/files/issues/user.module_11.diff (9.99 KB) This patch implements http://kika.trip.ee/images/drupal_tabs_accessrules-183.png. Differences from mockup, most are noted in the mockup as something unclear or needing more work: - The columns are ordered such that when read from left to right they make sense. - The form is ordered the same way. - The two radio button groups are not side by side. - The help text is better. - There are no nice icons. (The watchdog 'stop' icon is nice, but it has 'watchdog' in the filename. There is nothing green.) - Used an h3 tag instead of a form group, which is more consistent across Drupal. - Added the check rules UI at the bottom. ------------------------------------------------------------------------ January 25, 2005 - 21:14 : drumm Setting status to patch. ------------------------------------------------------------------------ January 25, 2005 - 21:36 : Dries Tres cool! However, I do think form_group()s might help unclutter the interface. On your screenshot (and on my local test site using Chameleon) it is hard to see where each part of the page starts (and ends). The visual difference between the headers and the form titles are too small to be confortable. I like Kristjan's form_group()s better. -- View: http://drupal.org/node/16176 Edit: http://drupal.org/project/comments/add/16176