On 31-Oct-06, at 9:46 AM, Dries Buytaert wrote:
On 31 Oct 2006, at 15:35, Moshe Weitzman wrote:
dries, killes, et al, can we open a discussion about running the subscriptions.module (or equivalent, if there's a better alternative in contrib already) on d.o, so i don't have to re- invent the wheel, just for the sake of being "inside" project*.module?
that discussion is easy - subscriptions module has some ugly code in it and needs significant cleanup. Ideally, the best parts are salvaged and submitted to core as a patch. i wouldn't run it on groups site, and i'm more aggressive than d.o. volunteers are encouraged to work up this patch.
I'd have to look at subscriptions.module first (don't turn out modules on drupal.org without a decent security review). That said, I'd love to have e-mail subscriptions in core -- even if it is a fairly naive implementation.
If we're going to go that route I'd rather see a general subscription framework (no, I'm not going to say "API" ;) in core. There are lots of other ways that a someone could be notified of subscriptions (i.e. Jabber/XMPP, etc). It'd be nice if things could tie in there. So a subscriptions framework would really just keep track of what nodes/ terms/etc are subscribed and offer a hook for implementations to do the notifying. Code is gold? :P -- James Walker :: http://walkah.net/ :: xmpp:walkah@walkah.net