Issue status update for http://drupal.org/node/25634 Post a follow up: http://drupal.org/project/comments/add/25634 Project: Drupal Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: walkah Status: patch let me weigh in +1 on the mixed parameter side ... let's get away from blowing up backwards compatibility unless it's justified and/or unavoidable for the sake of progress. please :) walkah Previous comments: ------------------------------------------------------------------------ June 23, 2005 - 13:37 : chx Attachment: http://drupal.org/files/issues/node_load.patch (2.23 KB) I am fed up writing node_load(array('nid' => $nid)) all the time. BTW. if this is accepted, next is node_view to accept a $nid. ------------------------------------------------------------------------ June 23, 2005 - 13:41 : chx Attachment: http://drupal.org/files/issues/node_load_0.patch (2.23 KB) ------------------------------------------------------------------------ June 23, 2005 - 13:53 : adrian I am going to +1 this. node_load(x) is much more natural to type. Having it use an array if found is useful too though. ------------------------------------------------------------------------ July 1, 2005 - 12:00 : chx Attachment: http://drupal.org/files/issues/node_load_1.patch (27.89 KB) Dries, if I remember correctly, you favoured this approach. ------------------------------------------------------------------------ July 1, 2005 - 12:07 : chx Attachment: http://drupal.org/files/issues/node_load_2.patch (27.97 KB) PHPdoc. ------------------------------------------------------------------------ July 1, 2005 - 12:14 : Jose A Reyero +1 It's not only about lazy developers -which I am ;-)- it's also about shorter code => less errors, easier to catch ------------------------------------------------------------------------ July 1, 2005 - 12:17 : chx The patch and its consequences makes me love the version at http://drupal.org/node/25634#comment-33584 more, but Dries will be the one to decide. ------------------------------------------------------------------------ July 1, 2005 - 12:31 : chx Attachment: http://drupal.org/files/issues/node_load_3.patch (18.95 KB) A few things slipped in from another patch which should not be here. ------------------------------------------------------------------------ July 1, 2005 - 12:33 : chx Attachment: http://drupal.org/files/issues/node_load_4.patch (15.31 KB) Same problem as above. ------------------------------------------------------------------------ July 15, 2005 - 00:10 : clydefrog I like this! Is there a similar issue for user_load()? ------------------------------------------------------------------------ July 16, 2005 - 01:33 : Steven I definitely prefer the version where we simply allow $conditions to be passed as an integer, rather than introducing additional parameters. It matches PHP's convention of having "mixed" argument types for some functions for shorthands (e.g. str_replace allows array arguments to compact multiple replacements in one statement). And not unimportant: it does not break backwards compatibility for what it essentially syntactic sugar. ------------------------------------------------------------------------ July 16, 2005 - 02:58 : chx Steven. Dries did not like that version hence the additional parameter. Dries, now that even Steven is on my side, would you please reconsider :) ? ------------------------------------------------------------------------ July 16, 2005 - 04:01 : adrian I concurr about the mixed parameter.