Jeremy Andrews wrote:
On Fri, 14 Jul 2006 15:45:35 +0200 (CEST) Gabor Hojtsy <gabor@hojtsy.hu> wrote:
- come up with some custom process of providing translations for the installer, like a simple key->value pair text file.
When I started the installer patch, my intention for translations was to emulate the t() function (under a different name), loading translations from a text file rather than the database, with a simple key-value pair as you describe.
Where you run into a problem is when there's shared messages, ie as is desired by the requirements api which could also be used by Drupal itself when enabling modules, as well as by the installer during initial setup. Any text displayed by Drupal is already wrapped in t(), so I think the logical thing to do is to expand t() to support both reading mappings from text fiels in addition to from the database. Then t() could be consistently used in all code, including the installer.
t() is called at least several dozen times per page, any complication should be avoided. The installer is a one time thing and should not impact the running of the site. Cheers, Gerhard
Cheers, -Jeremy