Issue status update for http://drupal.org/node/22494 Project: Drupal Version: cvs Component: watchdog.module Category: feature requests Priority: minor Assigned to: Anonymous Reported by: baudolino Updated by: baudolino Status: patch Attachment: http://drupal.org/files/issues/watchdog.add_IP_lookup_1.diff (957 bytes) Updated version, removed "target=_blank". baudolino Previous comments: ------------------------------------------------------------------------ May 9, 2005 - 23:27 : baudolino Attachment: http://drupal.org/files/issues/watchdog.add_IP_lookup.diff (972 bytes) This small patch adds IP lookup capabilities to the watchdog module using the free external site http://whois.sc. Basically, the IP becomes clickable, and a new window opens which displays a lot of data about the address in question. Might be useful for site administrators who need to look at suspicious activites, spiders, harvesters etc. I got this idea from the phpBB bulletin board software, which offers this feature for administrators. One line patch attached. ------------------------------------------------------------------------ May 10, 2005 - 09:46 : kbahey +1 for this patch. Shouldn't target="blank" read target="_blank" (with under score)? ------------------------------------------------------------------------ May 10, 2005 - 10:25 : Junyor -1 for using the target attribute. That's browsers UI functionality. ------------------------------------------------------------------------ May 10, 2005 - 11:32 : Bèr Kessels another -1 on target blank; As nielsen points out (http://www.useit.com/alertbox/9605.html #9) opening new windows is "Opening up new browser windows is like a vacuum cleaner sales person who starts a visit by emptying an ash tray on the customer's carpet. Don't pollute my screen with any more windows, thanks (particularly since current operating systems have miserable window management). "