On Mon, 9 May 2005, Dries Buytaert wrote:
On 09 May 2005, at 18:55, Dries Buytaert wrote:
That or _forum_user_last_visit() should only load/cache information about the nodes in the relevant forum (i.e. add a left join). Even so, we risk doing some work twice. We'll need to do some profiling for this ...
I did some quick measurements.
:) I created an issue for this: http://drupal.org/node/22420
1. If one has a small history (40 rows in the history table), _forum_user_last_visit() is faster than node_last_viewed().
2. If one has a large history (550 rows in the history table), node_last_viewed() is slightly faster than _forum_user_last_visit().
This is 550 rows per user I assume?
The difference is less than 10 ms but most of the time _forum_user_last_visit() is the fastest. If we change the current behavior to tidy up or unify the code, performance is going to degrade slightly. Unless, of course we can improve the performance of node_last_viewed().
no idea how to achieve this. Cheers, Gerhard