On Wed, 2007-02-07 at 19:37 +0100, Gerhard Killesreiter wrote:
Robert Douglass wrote:
Boris Mann wrote:
On 2/7/07, Robert Douglass <rob@robshouse.net> wrote:
This is actually a very good idea, imo. The best format for this would be to select the drupal version and file that you've changed (or multiple), upload the files, and then have the patch generated. I think this could be done securely as long as the files didn't land in the web directory. This would certainly be an invaluable service.
I'm all for lowering barriers to entry. I wonder about the quality of code from such a system. Figuring out patch/diff and CVS is good for the soul, not to mention best practices of code development.
True. But I think we could get reasonable patches from such a system, and could do things like strip Windows line breaks, spaces at end of lines, and so forth. We could even run it through the code style script to preempt errors.
I believe that people not able and/or willing to provide proper patches will probably only provide second rate code anyway and it isn't worth the bother.
I agree with killes. If a user can't diff... I'd expect patches against the wrong version of a module and/or patches that provide poor or incorrect solutions to problems.