Thanks for catching that. I really think we should just get those instructions out of there. To fix git documentation, please file issues at http://drupal.org/project/git_dev Thanks, -Randy On Thu, Apr 14, 2011 at 2:04 PM, Guillaume <guillaume@resist.ca> wrote:
This doc needs to be fixed then: http://drupal.org/patch/create
It says to use: diff -up path/to/file/example.module path/to/file/exampleNew.module > mypatchname.patch
Which produces p0 patches :(.
G
On 04/11/2011 01:21 PM, Randy Fay wrote:
I noticed in another thread that somebody suggested git diff --no-prefix for creating patches.
Please don't do that any more. We've moved to standard git patches (git diff without the --no-prefix, meaning a patch -p1 patch).
Testbot support for -p0 patches (--no-prefix) will be removed around the end of May. See http://groups.drupal.org/node/140204
Some of you may have the --no-prefix stuff in your .gitconfig. Please remove it from there as well.
In the issue queues, please start to insist on rerolls for -p0 formatted patches (if they have no a/ and b/ in front of the filenames.
Thanks for your cooperation.
-Randy
-- Randy Fay Drupal Module and Site Development randy@randyfay.com <mailto:randy@randyfay.com> +1 970.462.7450
-- Randy Fay Drupal Module and Site Development randy@randyfay.com +1 970.462.7450