On 10/31/06, Dries Buytaert <dries.buytaert@gmail.com> wrote:
On 31 Oct 2006, at 15:35, Moshe Weitzman wrote:
dries, killes, et al, can we open a discussion about running the subscriptions.module (or equivalent, if there's a better alternative in contrib already) on d.o, so i don't have to re- invent the wheel, just for the sake of being "inside" project*.module?
that discussion is easy - subscriptions module has some ugly code in it and needs significant cleanup. Ideally, the best parts are salvaged and submitted to core as a patch. i wouldn't run it on groups site, and i'm more aggressive than d.o. volunteers are encouraged to work up this patch.
I'd have to look at subscriptions.module first (don't turn out modules on drupal.org without a decent security review). That said, I'd love to have e-mail subscriptions in core -- even if it is a fairly naive implementation.
Subscriptions (with an 's') is the best of a bad bunch. I won't comment on the code (it works, after all), but here's my list: Must have: * instead of just including a link to the updated content, allow for selection between title + link, title + teaser, and full update (same would apply to comments) Nice to have: * digest mode: allow sending of X updates and/or sending after Y days -- Boris Mann Vancouver 778-896-2747 San Francisco 415-367-3595 Skype borismann http://www.bryght.com