Issue status update for http://drupal.org/node/21221 Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: robertDouglass Updated by: Dries Status: patch The next logical step is to do the same for node.module and to unify both (they are inverse now) to STATUS_PUBLISHED and STATUS_NOT_PUBLISHED. Dries Previous comments: ------------------------------------------------------------------------ April 24, 2005 - 17:55 : robertDouglass Attachment: http://drupal.org/files/issues/comment_constants.patch.txt (9.89 KB) Reading the comment.module is more confusing than necessary because of all the comparisons $status = 0 or $status = 1. What does this mean? If one were to go by the example in node or users, 0 would be unpublished. Not so with comments, thus the confusion. The fix is to define constants and use them instead of 0 and 1. That's what this patch does.