Project: Drupal Version: cvs Component: database system Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: Jose A Reyero Status: patch I like it!, though I still miss some more info about what the query is about -the 'hints' stuff- , but it's fine... :-) But also think there should be some kind of 'guidelines' about wrapping specific queries or not. For the moment, my candidates are: - node queries, which means 'queries that select lists of nodes', not any query which contains 'node' - taxonomy queries, same here, 'queries that select lists of vocabularies/terms' Both types of queries above are good candidates for joining permissions conditions, and maybe language conditions (i18n). And maybe more in the future.... we'll see. Jose A Reyero Previous comments: ------------------------------------------------------------------------ January 24, 2005 - 19:58 : chx Attachment: http://drupal.org/files/issues/db_rewrite_sql.patch (7.66 KB) As I was thinking on the various usages of node_rewrite_sql , it came to my mind that with very little changes it can be generalized so that any queries against any table -- not just node -- can be rewritten. I have moved node_rewrite_sql to database.inc, renamed it db_rewrite_sql, introduced another necessary parameter, which does not affect the current (light) usage of node_rewrite_sql. I think the usage is even clearer now, 'cos I think nid_alias caused some confusion. Now it is called $primary_table , while the new parameter is called $primary_key. What this would be good for? One may want to have permission and languages for taxonomy terms and vocabularies. ------------------------------------------------------------------------ January 24, 2005 - 23:08 : Dries I guess it makes sense to go with a generic approach, though it is difficult to predict how many queries will end up being wrapped in a call to db_rewrite_sql() ... Comments? -- View: http://drupal.org/node/16111 Edit: http://drupal.org/project/comments/add/16111