On Thursday 22 November 2007, Gábor Hojtsy wrote:
On Nov 22, 2007 7:45 PM, Larry Garfield <larry@garfieldtech.com> wrote:
... As of beta 3, all core modules have been split up with the exception of locale, which is already split in a somewhat bizarre way by putting all of its page handlers into locale.inc. I'm not certain it's worth refactoring that when in beta 3 stage, when there wouldn't be any significant difference in the amount of code that's loaded. (Gabor, I defer to you on that one.)
I have commented on the issue with some immediate concerns, but none of the tools (my issues, issue search, etc) is good for people like me who comment on an enourmous amount of patches, so a direct patch URL would be nice :) Also, it needs some reroll, as we fixed quite some stuff around there, since it was submitted. I still think to complete the split, locale stuff would be great to move properly to modules/locale and only the really required include code left in includes, which that patch is up to do.
Gabor
I was asking more in general terms rather than about the specific patch. For locale, it would really just be code tidying, not a performance boost, so I wasn't sure if it was worth it in beta 3 state. If you say yes, though, I'll see about redoing it. (The last version of the patch sucked for various reasons.) -- Larry Garfield AIM: LOLG42 larry@garfieldtech.com ICQ: 6817012 "If nature has made any one thing less susceptible than all others of exclusive property, it is the action of the thinking power called an idea, which an individual may exclusively possess as long as he keeps it to himself; but the moment it is divulged, it forces itself into the possession of every one, and the receiver cannot dispossess himself of it." -- Thomas Jefferson