Issue status update for http://drupal.org/node/29281 Post a follow up: http://drupal.org/project/comments/add/29281 Project: Drupal Version: cvs Component: theme system Category: feature requests Priority: normal Assigned to: moshe weitzman Reported by: moshe weitzman Updated by: moshe weitzman -Status: patch (code needs review) +Status: patch (ready to be committed) thanks for the icons ... this feature already works for the who's new and who's online blocks. perhaps someone (steven?) can add some css to include these images. otherwise, lets just get this improved markup committed. moshe weitzman Previous comments: ------------------------------------------------------------------------ Sun, 21 Aug 2005 01:01:04 +0000 : moshe weitzman Attachment: http://drupal.org/files/issues/online.patch (9.41 KB) add css class such that a theme can put nice online/offline indicators when showing a username link. i made sure the relevant queries in node, user, and tracker modules were passing the $user->access parameter which triggers the addition of this css class. no added quries or JOINS needed.much of this patch is just moving the 'inactivity timer' pref from the Who's Online block config page to the main admin/settings/user page. would be nice if someone contributed small graphics for online offline and added these to drupal.css. this would enhance our default presentation. i'd like for this patch not to wait on that, if possible. ------------------------------------------------------------------------ Sun, 21 Aug 2005 09:10:41 +0000 : Bèr Kessels I really like thi. +1. I managed to grey out my avatars of offline users (looks very good!) with this patch. One thing is the whos online block. IMO that should follow these same rules. ------------------------------------------------------------------------ Sun, 21 Aug 2005 14:01:35 +0000 : moshe weitzman Attachment: http://drupal.org/files/issues/online_0.patch (10.22 KB) this feature already works for the who's new and who's online blocks. here is a slightly improved version which adds offline indicator even for admin created users who have not yet logged in. ------------------------------------------------------------------------ Sun, 21 Aug 2005 14:30:23 +0000 : Maat@drupal.hu I patched a clean cvs install, but there are no classes in the tags of names of the owners of the nodes. I didn't can fix it and I have to go away. I drew the icons for the default theme: http://maat.myip.hu/~maat/maat_drupal/drupal/misc/online.png & http://maat.myip.hu/~maat/maat_drupal/drupal/misc/offline.png ------------------------------------------------------------------------ Sun, 21 Aug 2005 15:03:52 +0000 : Bèr Kessels Excuse my ignorance. This pach already changed the whos online block. My testsite had a too complex theme function, it was causing the whosonline block to check fro the old variable still. My error. But my +1 still stands, though.