Chris Johnson wrote:
I haven't looked at the code, but it's clear from Morbus' complaints that an equally long list of almost the very same complaints could be made about many of the core files.
Some of Morbus' complaints could have resulted directly from Matthew copying style and technique from core modules. Others are purely religious war sorts of issues, i.e. declaring defaults.
Generally I find this sort of post to be an ill-tempered and nit-picky, rather than useful.
It's generally not a good idea to nit-pick other's code, especially in public, unless you are yourself perfect -- which no one is.
I hereby invite and authorize everybody to nitpick on any code I have ever written, be it in private or public. Preferably by attaching a patch file which points out my errors. There were times I'd have paid a lot of money to get a free lecture like Morbus provided.
And that means it just degenerates into a pissing contest of finding faults with each other. That's not a productive use of time, in my view.
Well, our views could not be more different. Morbus' infuriated letter has resulted in a better module whereas all the bickering by other people has only temporarily filled my inbox. Cheers, Gerhard