Issue status update for http://drupal.org/node/29283 Post a follow up: http://drupal.org/project/comments/add/29283 Project: Drupal Version: cvs Component: theme system Category: bug reports Priority: normal Assigned to: moshe weitzman Reported by: moshe weitzman Updated by: fajerstarter Status: patch (code needs review) ... wrapped with <?php if ... ?> ... sorry... BTW, the preview function doesn't work :) fajerstarter Previous comments: ------------------------------------------------------------------------ Sun, 21 Aug 2005 01:49:53 +0000 : moshe weitzman Attachment: http://drupal.org/files/issues/logo.patch (830 bytes) if admin chooses no logo in theme config, bluemarine still lays down an img tag which points back to the site home page. thats a sure way to increase your load and bandwidth. yikes! ------------------------------------------------------------------------ Sun, 21 Aug 2005 01:53:19 +0000 : moshe weitzman pushbutton already avoids this mistake so i copied its code. ------------------------------------------------------------------------ Sun, 21 Aug 2005 11:51:27 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/logo_0.patch (791 bytes) The patch is broken. Here's a fixed one. ------------------------------------------------------------------------ Sun, 21 Aug 2005 12:01:01 +0000 : fajerstarter When your at it: shouldn't .., .. etc. be wrapped with to remove the empty when not in use. Cleaner XHTML output. Or is it too expesive to check that for each div? ------------------------------------------------------------------------ Sun, 21 Aug 2005 12:06:46 +0000 : fajerstarter My mistake :) I meant: Shouldn't <div class='site-slogan'>... </div> , <div id="secondary">... </div> etc. be wrapped with to remove the empty when not in use. Cleaner XHTML output. Or is it too expesive to check that for each div?