On Saturday, 31. May 2008, Earl Miles wrote:
Jakob Petsovits wrote:
On the other hand, just recently I noticed a missing break; statement somewhere in Views. Checked out with CVS. But it didn't directly concern me or pose any problems to what I was doing, and opening up a new issue would have taken more time and effort than I was willing to put in. Like, "someone will probably fix it anyways". With commit access, I would have committed the fix right away, and in the unlikely case that it's actually wrong (and a "// fall through" comment would be required instead) then Earl would have noticed and fixed it the right way. It's probably still unfixed, I guess.
Now you can critizise me for being lazy, but I think this is symptomatic and happens all the time. If we want to scale contrib, we need to lower the contribution barrier for people who are able to fix stuff, while raising the barrier for people who break stuff.
I just grepped and looked at 43 instances of switch() in Views 1.
I find one case that might look like a missing break in the theme wizard; and it's kind of odd. Otherwise, nada. Waste of my time.
Views 2. Ok, let me see if I can dig this up again... don't know anymore where I found it, but perhaps it's still in there somewhere. See you in your issue queue, Jakob