Issue status update for http://drupal.org/node/24135 Project: Drupal Version: cvs Component: statistics.module Category: feature requests Priority: normal Assigned to: moshe weitzman Reported by: moshe weitzman Updated by: breyten Status: patch Having a table would allow for a simple query like: $result = db_query("SELECT * FROM {banned_hosts} WHERE ipaddr = '%s'", $_SERVER["REMOTE_ADDR"]); which is probably faster than a combined in_array and array_keys I suppose. breyten Previous comments: ------------------------------------------------------------------------ June 2, 2005 - 07:54 : moshe weitzman Attachment: http://drupal.org/files/issues/ban.diff (5.94 KB) The intent of this patch is to provide an easy way to ban hosts that are consuming too much bandwidth. Ideal for over-aggressive crawlers. ------------------------------------------------------------------------ June 2, 2005 - 07:59 : moshe weitzman Attachment: http://drupal.org/files/issues/ban_0.diff (5.95 KB) Oops. Here is the latest version. ------------------------------------------------------------------------ June 2, 2005 - 12:59 : Dries Any particular reason we are not storing this in the database? Storing it in the database sounds like the better option to me. ------------------------------------------------------------------------ June 2, 2005 - 13:15 : moshe weitzman well, we can't store it in the sessions table because many crawlers don't persist cookies and thus get a new session for every request. so we would have to store in a new table and I figured that I didn't need to add a new query for every page view. it would be a fast query, so perhaps a new table is OK. any more comments about variable table versus new table?