Issue status update for http://drupal.org/node/18216 Project: Drupal -Version: 4.5.0 +Version: cvs.tar Component: node.module Category: bug reports Priority: critical Assigned to: chx Reported by: chx Updated by: asimmonds Status: patch Err, somethings funny with the issue version field, changing back to cvs. asimmonds Previous comments: ------------------------------------------------------------------------ March 2, 2005 - 11:54 : chx Attachment: http://drupal.org/files/issues/nodeapi_settings.patch (2.49 KB) I have noticed this morning that hook_nodeapi is no longer called by $node as first argument as first setting, but only $type. I documented this in the handbook, 'cos I have thought this is well thought out decision which is executed through the core. But only node.module is updated, comment and upload is broken and every node module out there. I know we do not have backwards compatibility. I think it would be better to introduce a new hook for this. But, as we are in feature freeze, I doubt any of this shall happen. Instead, for now let's change the behaviour back. ------------------------------------------------------------------------ March 6, 2005 - 23:04 : chx http://drupal.org/node/16384 ------------------------------------------------------------------------ March 6, 2005 - 23:11 : chx Resetting to patch, as Dries just commented this as 'slightly better'. ------------------------------------------------------------------------ March 7, 2005 - 18:46 : asimmonds Attachment: http://drupal.org/files/issues/nodeapi_settings_2.patch (2.92 KB) Slightly updated patch that now does both $node->type references in the form_checkboxes call, and the change to the phpDOC.