19 Feb
2005
19 Feb
'05
5:21 p.m.
Nedjo Rogers said:
Nice work. Likely we could adapt some approaches from, e.g., the PEAR PHP_Beautifier package, http://pear.php.net/package/PHP_Beautifier. For actually fixing up non-compliant code, contributors could use PHP_Beautifier directly, if a noble volunteer would write a new "filter" for Drupal coding styles, modelled on, e.g., the existing PEAR filter (see the file Beatutifier/Filter/PEAR.filter.php in the distribution).
It would probably save a bit of work if all patches were run through the same kind of filter as Dries wrote. It could check for the same code style problems and also check if the patch was made using the correct diff parameters. -- Tim Altman