This is the type of concern I was trying to fish out, if it existed, when I started this topic. The issue of files staying in the files directory that never get submitted to associate to a final post seems important to me, too. Even if some filesystems can handle 1 million files, it doesn't seem like the correct way to do organize. I don't have a 50,000 file problem (yet), but would a patch be welcome on this (if I get the free time)? I'm thinking either each node would have its own directory in files, each module would, or both. I'm not familiar with the famous Craig patch, but is this in line with it? Option A: files/1/file.jpg files/1/another.png files/2/separatenode.gif Option B: files/blog.module/file.jpg files/project.module/patch.diff Option C (the ultimate in eliminating filename collisions): files/blog.module/12/wedding.png files/project.module/14/another.doc Robert Douglass wrote:
I think we will see more and more cases like this:
unfortunately I can't even begin to think about doing the work needed to upgrade our file API based on Craig's work or other ideas. I can only be a cheerleader for this one.
Robert
Matt Westgate wrote:
On Monday 27 June 2005 09:17 am, Robert Douglass wrote:
Just for the record, I've long wished that Craig's code had been the code that 'won' the upload.module contest the last time this issue went around.
I had a lot of interest in Craig's code as well. It allowed modules to declare if they wanted to use public or private files rather than default to whatever the site uses. Matt