+1 to this concept, though it seems that it should be ok for themes to provide their own... Therefore if you specify a custom favicon in the theme admin section, you override the default, but otherwise the default is used. The pseudo-code in the theme would look like: if {drupal-favicon} output link to drupal-favicon else output link to theme-favicon end if -1 for putting the favicon in drupal_get_html_head. I also think that you should be able to upload the favicon like you can a logo in the theme admin section and that this should be a global theme setting instead of the current "enter a relative path for the favicon". Chris On 4/18/05, nysus <drupal-devel@drupal.org> wrote:
Issue status update for http://drupal.org/node/20809
Project: Drupal Version: cvs Component: theme system Category: feature requests Priority: normal Assigned to: nysus Reported by: nysus Updated by: nysus Status: patch Attachment: http://drupal.org/files/issues/favicon.patch (4.57 KB)
Here is a patch that allows a user to manually set the path to the "favicon.ico" file. It makes a single change to the user interface: it adds a text field to the "Logo image setting" section of the "themes/settings" page.
This is especially useful for sites sharing a single code base as you no longer need to create a new theme just so you can have a distinct favicon.ico.
nysus