Hi Yves, I think you have a good point regarding the rendering of the links. Perhaps it would be better to separate this into two issues: 1 - add keys to links 2 - change links to be rendered by themes or modules (I don't feel like I know enough about drupal to say what's right here) But, in my world it's really only #1 that is important. If it is a minor change, perhaps we could implement this first and deal with #2 after #1 is in place. Regards, Justin On Thu, May 11, 2006 at 01:23:55AM +0200, Yves CHEDEMOIS wrote:
+1 for the idea of separating the $links soup into several keys I'm not sure this is coherent with the rest of core, but I like the possibilites left to theme (filtering out, ordering...)
I think leaving the render of the links to the themes is not a good idea, however :
Having html code produced by l ("el"...) outside a theme function is considered OK, so what's the point of having a supplemental layer ? (plus you'd have to support the other params l handles : querystring, fragment...)
Besides, modules might want to output other things than an actual <a> tag (simple text, whatever...). They are currently allowed to do so, which I think is a good thing. If their output is "complicated", it is up to the module coder ("good coding practice") to have a theme function provide that output.