27 May
2005
27 May
'05
11:44 p.m.
Nice functionality. Question about coding conventions; I assume that Drupal coding conventions apply to our js code as well? If so, I believe one should avoid the use of conditional statements that depend on the "line after" rule and use {} in all cases. I find this block especially disturbing to read: + if (callback_function) + xmlhttp.onreadystatechange = function() { + if (xmlhttp.readyState == 4) + callback_function(xmlhttp.responseText, xmlhttp, callback_parameter) + } To me these are just accidents waiting to happen (with the brackets). -Robert