Thanks Jeff! I'd like to clarify one misconception about coder ... it's not just for coding standards. The name coder stands for "Code Review", and code review can take many shapes and sizes. Coder is a nice platform for writing "reviews" and "rules" that can be used to look for almost anything. This email thread is about the 6.x upgrade review. This review will assist all of us with the 6.x module upgrades, and hopefully speed up this process. Doug Green 904-583-3342 www.douggreenconsulting.com Bringing Ideas to Life with Software Artistry and Invention... Providing open source software political solutions -----Original Message----- From: development-bounces@drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Jeff Eaton Sent: Saturday, June 02, 2007 11:55 AM To: development@drupal.org Subject: Re: [development] coder and 6.x core remaining upgrades On Jun 2, 2007, at 10:36 AM, Doug Green wrote:
f you're working on core for 6.x, I'd like you to know that http:// drupal.org/project/coder's 6.x upgrade review is now current. The HEAD version of coder works on the current Drupal HEAD, and if you run it on Drupal core itself it finds about 30 problems ranging including many argument changes to l(), url(), watchdog t()'s no longer needed. Since these upgrades span several modules and since I'm not aware of the fix really needed (for example, #multistep in poll.module), it seemed more appropriate just to let the core developers know that there are a few minor issues, and that coder should help you find many of them. Thanks!
I've used Coder in the past when cleaning up the VotingAPI code and the results were really nice. It's awesome that we're starting to apply our coding standards to the core modules that were around before those standards evolved. ;) The #multistep issue in poll is fixed in the $form-state patch; it's easy to miss in the mass of stuff there. ;) --Jeff