Actually, there was a successful effort in last year's Summer of Code to build an automatic test suite. It was easy to use... you'd upload your patch and the system did a clean checkout of Drupal, applied the patch (first point of failure... patch doesn't apply), and then ran a battery of tests (which could easily include code style). This system is still being developed and with proper encouragement could be fleshed out and made a part of our infrastructure. It could then automatically grab core patches and put them through the wringer as being a pre-requisite to RTBC even being an option. For this type of stuff to happen, we need better support from the Drupal Association, since that is the body that is responsible for d.o. infrastructure. -Robert adrian rossouw wrote:
On 02 Jul 2007, at 9:30 AM, Gerhard Killesreiter wrote:
"It works" isn't all that's needed. It should follow the coding style as
well as being done "the Drupal way"(tm).
Can't we force patches to be run through code-style.pl before being considered for committing ?