Issue status update for http://drupal.org/node/17955 Project: Drupal Version: cvs Component: taxonomy.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: Dries Status: patch Ber: the confirmation page is less like the others we have. What makes you believe it looks more like the others? Dries Previous comments: ------------------------------------------------------------------------ February 25, 2005 - 19:26 : drumm Attachment: http://drupal.org/files/issues/taxonomy.module_3.diff (4.94 KB) form_item() isn't right in a few cases. Such as confirmation pages and things which should be using other form functions. There was a subtle difference between form_select() and whatever taxonomy was doing. Thats why there is extra code here. I tested it a bit too. ------------------------------------------------------------------------ February 28, 2005 - 15:05 : Bèr Kessels +1 from me. Untill we have a general confirmation API, we should use something like this. Furthermore the form_select, instead of an ugly looped selector genreator makes sense. ------------------------------------------------------------------------ February 28, 2005 - 18:31 : Dries All other configuration pages (eg. locale module, menu module, etc.) all use form_item(). I'm likely to drop that bit, and have yet to see the feasability of a 'confirmation API' (it sounds difficult). (Ber: it is not clear from your review whether you tested the patch or not.) ------------------------------------------------------------------------ February 28, 2005 - 19:28 : Bèr Kessels Dries, I did not test the patch thouroughly. But from what I have seen and tested, the functionality does not change at all. Only the confirmation page looks more like the others we have. Off-topic: Some handbook page with a test-program might be handy. I, for example have very little professional experience with testing. i just install it and click around a bit, but there must be some good methods.