Issue status update for http://drupal.org/node/31323 Post a follow up: http://drupal.org/project/comments/add/31323 Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: critical Assigned to: Anonymous Reported by: Souvent22 Updated by: Souvent22 Status: patch (code needs review) Attachment: http://drupal.org/files/issues/clean_node.revisions_1.patch (1.44 KB) Some more wording issues, but i think this is ready to go. Souvent22 Previous comments: ------------------------------------------------------------------------ Thu, 15 Sep 2005 17:36:16 +0000 : Souvent22 Attachment: http://drupal.org/files/issues/node_revisions.patch (1.39 KB) When you delete a revision, nothing is fired to tell other modules that a revision of that node has been deleted. This patch fires a _invoke_nodeapi" so that other modules will know, and can catch the event that a revision of a node has been deleted, and then take the correct action. This is needed for other modules such as 'upload.module', which keeps files for each revision. This patch also creates a watchdog entry when a revision is deleted. I'm sure the wording of the watch dog entry, if it should be watched, _invoke vs another paramenter, etc. will be argued, but I wanted to get this up, so I can hear the arguments, and get this quared away and patched it. I think this is really important. Thanks. ------------------------------------------------------------------------ Thu, 15 Sep 2005 17:43:01 +0000 : Souvent22 Attachment: http://drupal.org/files/issues/clean_node.revisions.patch (1.39 KB) Got fuzz warning, cleaned up my patch. Samething, just patches easier. ------------------------------------------------------------------------ Thu, 15 Sep 2005 17:55:28 +0000 : Souvent22 Attachment: http://drupal.org/files/issues/clean_node.revisions_0.patch (1.32 KB) Changed working for the watchdog and for the messege that reported after deletion.