well, after three development cycles, i've apparently written something worth committing for Drupal's deletion system... ;) thanks to all the folks who helped it along, esp. chx and steven -- couldn't have done it w/o you! now, on to other matters: upgrade docs are done, and here: http://drupal.org/node/ 114774#deletion-api a complete writeup on the API is here: http://drupal.org/node/153904 hook_delete_pre() and hook_delete_alter() have been added to the developer docs in contrib. the new functions are on api.drupal.org in HEAD. their formatting is a bit crappy, and i'm not sure if that's an api module bug or something i did. at any rate they're usable, and i'll look into getting them prettier in a bit. :) currently, only node and comment deletions use the API in core. we have about 8 days until the code freeze, so i wanted to get opinions on what else in core we might want to try and convert. IMO, the one that should definitely get converted is user deletions, which i'm happy to write. anybody else have thoughts on other important areas that we should focus on before the code freeze??
Does handling content type deletion make sense ?
See http://drupal.org/node/92329 I'm sure there's is plenty of other issues around On 6/23/07, Yves Chedemois <yched.drupal@free.fr> wrote:
Does handling content type deletion make sense ?
-- Regards, Johan Forngren :: http://johan.forngren.com/
Chad, I've just gone through the handbook pages you did on the API. They describe the API well, but I don't think I grok the "user experience" that the API implements. Am I right in assuming that the implementation generates a standard UI for deleting a "package" along with the various hooks it implements for letting other code respond to the deletion? Also, I found the explanation of the "package" concept a bit abstract. A real-world-ish example might help. Thanks, Rob Chad Phillips -- Apartment Lines wrote:
well, after three development cycles, i've apparently written something worth committing for Drupal's deletion system... ;)
thanks to all the folks who helped it along, esp. chx and steven -- couldn't have done it w/o you!
now, on to other matters:
upgrade docs are done, and here: http://drupal.org/node/114774#deletion-api
a complete writeup on the API is here: http://drupal.org/node/153904
hook_delete_pre() and hook_delete_alter() have been added to the developer docs in contrib.
the new functions are on api.drupal.org in HEAD. their formatting is a bit crappy, and i'm not sure if that's an api module bug or something i did. at any rate they're usable, and i'll look into getting them prettier in a bit. :)
currently, only node and comment deletions use the API in core. we have about 8 days until the code freeze, so i wanted to get opinions on what else in core we might want to try and convert. IMO, the one that should definitely get converted is user deletions, which i'm happy to write. anybody else have thoughts on other important areas that we should focus on before the code freeze??
Offhand, it looks like this could be very helpful for implementing foreign keys with CASCADE on delete (the only way we can possibly implement them). The trick with doing so is that we have to handle deletions for modules that are disabled because not all databases support foreign keys/CASCADE. Drupal core, or schema.module, or something could implement hook_delete_alter() to add any necessary delete statements for those disabled modules. Of course, this implies that the schema system needs to have the hook_schema results for all installed but disabled modules. That shouldn't be a problem to get. I still do not think this is doable in time for D6, though. But it is very interseting. Barry
As someone who was around when Chad started on this long path, let me say: Hip-hip hooray! Congratulations! You must feel a hundred pounds lighter now, Chad. :-) ..chris
participants (6)
-
Barry Jaspan -
Chad Phillips -- Apartment Lines -
Chris Johnson -
Johan Forngren -
Rob Thorne -
Yves Chedemois