[drupal-devel] [bug] Field location in table locales_source is too short in PostgreSQL
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: cvs Component: postgresql database Category: bug reports Priority: normal Assigned to: patryk Reported by: patryk Updated by: patryk Status: patch Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. patryk
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: cvs Component: postgresql database Category: bug reports Priority: normal Assigned to: patryk Reported by: patryk Updated by: Dries Status: patch There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? Dries Previous comments: ------------------------------------------------------------------------ April 25, 2005 - 03:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless.
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: cvs -Component: postgresql database +Component: database system Category: bug reports Priority: normal Assigned to: patryk Reported by: patryk Updated by: patryk Status: patch Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. patryk Previous comments: ------------------------------------------------------------------------ April 25, 2005 - 03:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 19:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible?
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: patryk Reported by: patryk Updated by: jhriggs -Status: fixed +Status: patch The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change? jhriggs Previous comments: ------------------------------------------------------------------------ April 24, 2005 - 20:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 12:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 15:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 11:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk.
Issue status update for http://drupal.org/node/21252 Project: Drupal -Version: cvs +Version: 4.6.0 Component: database system Category: bug reports -Priority: normal +Priority: critical Assigned to: patryk Reported by: patryk Updated by: jhriggs Status: patch I didn't realize the patch had been applied to 4.6 also. Marking as critical. jhriggs Previous comments: ------------------------------------------------------------------------ April 24, 2005 - 20:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 12:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 15:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 11:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 10:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change?
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: 4.6.0 Component: database system Category: bug reports Priority: critical Assigned to: patryk Reported by: patryk Updated by: patryk Status: patch Attachment: http://drupal.org/files/issues/drupal-cvs-locales-fix.diff (1.83 KB) I made a small investigation. Postgres eats 1 GB strings for breakfast unlike MySQL which sucks with it's 255 character limit until 5.0.3 excluding ;) (even 5.0.3 has limit of 65536 chars) Some references: http://www.postgresql.org/docs/7.4/interactive/datatype-character.html - as Drupal must use v7.4 at least http://dev.mysql.com/doc/mysql/en/char.html In the result let's do that field 255 chars long in both databases to be coherent. PS: I'm thinking about something to ease pgsql 7.4's column type change. 8.0 has it already implemented. Maybe some hyper-clever function? ;) The new patch against today's CVS attached. Includes updates in updates.inc. patryk Previous comments: ------------------------------------------------------------------------ April 25, 2005 - 03:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 19:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 22:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 18:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 17:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change? ------------------------------------------------------------------------ May 2, 2005 - 17:46 : jhriggs I didn't realize the patch had been applied to 4.6 also. Marking as critical.
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: 4.6.0 Component: database system Category: bug reports Priority: critical Assigned to: patryk Reported by: patryk Updated by: drumm Status: patch +1 for the database.mysql part which I sucessfully used. That file in the 4.6 branch is rather broken. drumm Previous comments: ------------------------------------------------------------------------ April 24, 2005 - 19:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 11:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 14:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 10:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 09:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change? ------------------------------------------------------------------------ May 2, 2005 - 09:46 : jhriggs I didn't realize the patch had been applied to 4.6 also. Marking as critical. ------------------------------------------------------------------------ May 2, 2005 - 14:02 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-locales-fix.diff (1.83 KB) I made a small investigation. Postgres eats 1 GB strings for breakfast unlike MySQL which sucks with it's 255 character limit until 5.0.3 excluding ;) (even 5.0.3 has limit of 65536 chars) Some references: http://www.postgresql.org/docs/7.4/interactive/datatype-character.html - as Drupal must use v7.4 at least http://dev.mysql.com/doc/mysql/en/char.html In the result let's do that field 255 chars long in both databases to be coherent. PS: I'm thinking about something to ease pgsql 7.4's column type change. 8.0 has it already implemented. Maybe some hyper-clever function? ;) The new patch against today's CVS attached. Includes updates in updates.inc.
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: 4.6.0 Component: database system Category: bug reports Priority: critical Assigned to: patryk Reported by: patryk Updated by: baudolino -Status: active +Status: patch Attachment: http://drupal.org/files/issues/update_135.patch.diff (1.38 KB) This should patch update.inc baudolino Previous comments: ------------------------------------------------------------------------ April 24, 2005 - 21:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 13:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 16:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 12:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 11:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change? ------------------------------------------------------------------------ May 2, 2005 - 11:46 : jhriggs I didn't realize the patch had been applied to 4.6 also. Marking as critical. ------------------------------------------------------------------------ May 2, 2005 - 16:02 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-locales-fix.diff (1.83 KB) I made a small investigation. Postgres eats 1 GB strings for breakfast unlike MySQL which sucks with it's 255 character limit until 5.0.3 excluding ;) (even 5.0.3 has limit of 65536 chars) Some references: http://www.postgresql.org/docs/7.4/interactive/datatype-character.html - as Drupal must use v7.4 at least http://dev.mysql.com/doc/mysql/en/char.html In the result let's do that field 255 chars long in both databases to be coherent. PS: I'm thinking about something to ease pgsql 7.4's column type change. 8.0 has it already implemented. Maybe some hyper-clever function? ;) The new patch against today's CVS attached. Includes updates in updates.inc. ------------------------------------------------------------------------ May 2, 2005 - 19:31 : drumm +1 for the database.mysql part which I sucessfully used. That file in the 4.6 branch is rather broken. ------------------------------------------------------------------------ May 3, 2005 - 01:20 : Dries Committed to HEAD. The update.inc-part did not apply against HEAD though. Marking this active.
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: 4.6.0 Component: database system Category: bug reports Priority: critical Assigned to: patryk Reported by: patryk Updated by: patryk Status: patch Attachment: http://drupal.org/files/issues/drupal-4-6-locales-fix.diff (1.21 KB) baudolino has provided the patch for HEAD's update.inc, I'm providing the same for DRUPAL-4-6's. Hope it is the last patch for this task :) patryk Previous comments: ------------------------------------------------------------------------ April 25, 2005 - 03:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 19:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 22:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 18:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 17:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change? ------------------------------------------------------------------------ May 2, 2005 - 17:46 : jhriggs I didn't realize the patch had been applied to 4.6 also. Marking as critical. ------------------------------------------------------------------------ May 2, 2005 - 22:02 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-locales-fix.diff (1.83 KB) I made a small investigation. Postgres eats 1 GB strings for breakfast unlike MySQL which sucks with it's 255 character limit until 5.0.3 excluding ;) (even 5.0.3 has limit of 65536 chars) Some references: http://www.postgresql.org/docs/7.4/interactive/datatype-character.html - as Drupal must use v7.4 at least http://dev.mysql.com/doc/mysql/en/char.html In the result let's do that field 255 chars long in both databases to be coherent. PS: I'm thinking about something to ease pgsql 7.4's column type change. 8.0 has it already implemented. Maybe some hyper-clever function? ;) The new patch against today's CVS attached. Includes updates in updates.inc. ------------------------------------------------------------------------ May 3, 2005 - 01:31 : drumm +1 for the database.mysql part which I sucessfully used. That file in the 4.6 branch is rather broken. ------------------------------------------------------------------------ May 3, 2005 - 07:20 : Dries Committed to HEAD. The update.inc-part did not apply against HEAD though. Marking this active. ------------------------------------------------------------------------ May 3, 2005 - 08:24 : baudolino Attachment: http://drupal.org/files/issues/update_135.patch.diff (1.38 KB) This should patch update.inc
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: 4.6.0 Component: database system Category: bug reports Priority: critical Assigned to: patryk Reported by: patryk Updated by: Dries Status: patch Patches no longer apply. Sorry. If time permits, please update the patches. Dries Previous comments: ------------------------------------------------------------------------ April 25, 2005 - 03:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 19:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 22:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 18:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 17:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change? ------------------------------------------------------------------------ May 2, 2005 - 17:46 : jhriggs I didn't realize the patch had been applied to 4.6 also. Marking as critical. ------------------------------------------------------------------------ May 2, 2005 - 22:02 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-locales-fix.diff (1.83 KB) I made a small investigation. Postgres eats 1 GB strings for breakfast unlike MySQL which sucks with it's 255 character limit until 5.0.3 excluding ;) (even 5.0.3 has limit of 65536 chars) Some references: http://www.postgresql.org/docs/7.4/interactive/datatype-character.html - as Drupal must use v7.4 at least http://dev.mysql.com/doc/mysql/en/char.html In the result let's do that field 255 chars long in both databases to be coherent. PS: I'm thinking about something to ease pgsql 7.4's column type change. 8.0 has it already implemented. Maybe some hyper-clever function? ;) The new patch against today's CVS attached. Includes updates in updates.inc. ------------------------------------------------------------------------ May 3, 2005 - 01:31 : drumm +1 for the database.mysql part which I sucessfully used. That file in the 4.6 branch is rather broken. ------------------------------------------------------------------------ May 3, 2005 - 07:20 : Dries Committed to HEAD. The update.inc-part did not apply against HEAD though. Marking this active. ------------------------------------------------------------------------ May 3, 2005 - 08:24 : baudolino Attachment: http://drupal.org/files/issues/update_135.patch.diff (1.38 KB) This should patch update.inc ------------------------------------------------------------------------ May 3, 2005 - 16:30 : patryk Attachment: http://drupal.org/files/issues/drupal-4-6-locales-fix.diff (1.21 KB) baudolino has provided the patch for HEAD's update.inc, I'm providing the same for DRUPAL-4-6's. Hope it is the last patch for this task :)
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: 4.6.0 Component: database system Category: bug reports Priority: critical Assigned to: patryk Reported by: patryk Updated by: baudolino Status: patch Attachment: http://drupal.org/files/issues/update_135_1.patch.HEAD.diff (1.54 KB) Here's the patch for HEAD. baudolino Previous comments: ------------------------------------------------------------------------ April 24, 2005 - 21:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 13:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 16:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 12:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 11:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change? ------------------------------------------------------------------------ May 2, 2005 - 11:46 : jhriggs I didn't realize the patch had been applied to 4.6 also. Marking as critical. ------------------------------------------------------------------------ May 2, 2005 - 16:02 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-locales-fix.diff (1.83 KB) I made a small investigation. Postgres eats 1 GB strings for breakfast unlike MySQL which sucks with it's 255 character limit until 5.0.3 excluding ;) (even 5.0.3 has limit of 65536 chars) Some references: http://www.postgresql.org/docs/7.4/interactive/datatype-character.html - as Drupal must use v7.4 at least http://dev.mysql.com/doc/mysql/en/char.html In the result let's do that field 255 chars long in both databases to be coherent. PS: I'm thinking about something to ease pgsql 7.4's column type change. 8.0 has it already implemented. Maybe some hyper-clever function? ;) The new patch against today's CVS attached. Includes updates in updates.inc. ------------------------------------------------------------------------ May 2, 2005 - 19:31 : drumm +1 for the database.mysql part which I sucessfully used. That file in the 4.6 branch is rather broken. ------------------------------------------------------------------------ May 3, 2005 - 01:20 : Dries Committed to HEAD. The update.inc-part did not apply against HEAD though. Marking this active. ------------------------------------------------------------------------ May 3, 2005 - 02:24 : baudolino Attachment: http://drupal.org/files/issues/update_135.patch.diff (1.38 KB) This should patch update.inc ------------------------------------------------------------------------ May 3, 2005 - 10:30 : patryk Attachment: http://drupal.org/files/issues/drupal-4-6-locales-fix.diff (1.21 KB) baudolino has provided the patch for HEAD's update.inc, I'm providing the same for DRUPAL-4-6's. Hope it is the last patch for this task :) ------------------------------------------------------------------------ May 6, 2005 - 05:04 : Dries Patches no longer apply. Sorry. If time permits, please update the patches.
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: 4.6.0 Component: database system Category: bug reports Priority: critical Assigned to: patryk Reported by: patryk Updated by: patryk Status: patch Attachment: http://drupal.org/files/issues/drupal-4_6-update131-add.diff (1.3 KB) patch against DRUPAL-4-6. Commit fast ;) patryk Previous comments: ------------------------------------------------------------------------ April 25, 2005 - 03:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 19:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 22:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 18:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 17:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change? ------------------------------------------------------------------------ May 2, 2005 - 17:46 : jhriggs I didn't realize the patch had been applied to 4.6 also. Marking as critical. ------------------------------------------------------------------------ May 2, 2005 - 22:02 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-locales-fix.diff (1.83 KB) I made a small investigation. Postgres eats 1 GB strings for breakfast unlike MySQL which sucks with it's 255 character limit until 5.0.3 excluding ;) (even 5.0.3 has limit of 65536 chars) Some references: http://www.postgresql.org/docs/7.4/interactive/datatype-character.html - as Drupal must use v7.4 at least http://dev.mysql.com/doc/mysql/en/char.html In the result let's do that field 255 chars long in both databases to be coherent. PS: I'm thinking about something to ease pgsql 7.4's column type change. 8.0 has it already implemented. Maybe some hyper-clever function? ;) The new patch against today's CVS attached. Includes updates in updates.inc. ------------------------------------------------------------------------ May 3, 2005 - 01:31 : drumm +1 for the database.mysql part which I sucessfully used. That file in the 4.6 branch is rather broken. ------------------------------------------------------------------------ May 3, 2005 - 07:20 : Dries Committed to HEAD. The update.inc-part did not apply against HEAD though. Marking this active. ------------------------------------------------------------------------ May 3, 2005 - 08:24 : baudolino Attachment: http://drupal.org/files/issues/update_135.patch.diff (1.38 KB) This should patch update.inc ------------------------------------------------------------------------ May 3, 2005 - 16:30 : patryk Attachment: http://drupal.org/files/issues/drupal-4-6-locales-fix.diff (1.21 KB) baudolino has provided the patch for HEAD's update.inc, I'm providing the same for DRUPAL-4-6's. Hope it is the last patch for this task :) ------------------------------------------------------------------------ May 6, 2005 - 11:04 : Dries Patches no longer apply. Sorry. If time permits, please update the patches. ------------------------------------------------------------------------ May 6, 2005 - 23:36 : baudolino Attachment: http://drupal.org/files/issues/update_135_1.patch.HEAD.diff (1.54 KB) Here's the patch for HEAD.
Issue status update for http://drupal.org/node/21252 Project: Drupal Version: 4.6.0 Component: database system Category: bug reports Priority: critical Assigned to: patryk Reported by: patryk Updated by: baudolino -Status: active +Status: patch Attachment: http://drupal.org/files/issues/drupal-4_6-HEAD-update137-add.diff (1.44 KB) Nevermind, didn't notice the silent update. Here we go again. Update 137 for HEAD coming up! baudolino Previous comments: ------------------------------------------------------------------------ April 24, 2005 - 21:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 13:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 16:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 12:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 11:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change? ------------------------------------------------------------------------ May 2, 2005 - 11:46 : jhriggs I didn't realize the patch had been applied to 4.6 also. Marking as critical. ------------------------------------------------------------------------ May 2, 2005 - 16:02 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-locales-fix.diff (1.83 KB) I made a small investigation. Postgres eats 1 GB strings for breakfast unlike MySQL which sucks with it's 255 character limit until 5.0.3 excluding ;) (even 5.0.3 has limit of 65536 chars) Some references: http://www.postgresql.org/docs/7.4/interactive/datatype-character.html - as Drupal must use v7.4 at least http://dev.mysql.com/doc/mysql/en/char.html In the result let's do that field 255 chars long in both databases to be coherent. PS: I'm thinking about something to ease pgsql 7.4's column type change. 8.0 has it already implemented. Maybe some hyper-clever function? ;) The new patch against today's CVS attached. Includes updates in updates.inc. ------------------------------------------------------------------------ May 2, 2005 - 19:31 : drumm +1 for the database.mysql part which I sucessfully used. That file in the 4.6 branch is rather broken. ------------------------------------------------------------------------ May 3, 2005 - 01:20 : Dries Committed to HEAD. The update.inc-part did not apply against HEAD though. Marking this active. ------------------------------------------------------------------------ May 3, 2005 - 02:24 : baudolino Attachment: http://drupal.org/files/issues/update_135.patch.diff (1.38 KB) This should patch update.inc ------------------------------------------------------------------------ May 3, 2005 - 10:30 : patryk Attachment: http://drupal.org/files/issues/drupal-4-6-locales-fix.diff (1.21 KB) baudolino has provided the patch for HEAD's update.inc, I'm providing the same for DRUPAL-4-6's. Hope it is the last patch for this task :) ------------------------------------------------------------------------ May 6, 2005 - 05:04 : Dries Patches no longer apply. Sorry. If time permits, please update the patches. ------------------------------------------------------------------------ May 6, 2005 - 17:36 : baudolino Attachment: http://drupal.org/files/issues/update_135_1.patch.HEAD.diff (1.54 KB) Here's the patch for HEAD. ------------------------------------------------------------------------ May 6, 2005 - 20:36 : patryk Attachment: http://drupal.org/files/issues/drupal-4_6-update131-add.diff (1.3 KB) patch against DRUPAL-4-6. Commit fast ;) ------------------------------------------------------------------------ May 7, 2005 - 04:56 : Dries Committed to DRUPAL-4-6. Thanks for your persistence Patryck. Marking this 'active' until we have an updated patch for HEAD. ------------------------------------------------------------------------ May 7, 2005 - 13:35 : baudolino The patch I submitted for HEAD before patryk sent his for 4.6 is updated and applies! Don't let the 135 in the name fool you, I just inserted it before the last update (which becomes 136), since chronologically that's what happened. Why would it make a difference in HEAD the order in which they're numbered?
participants (5)
-
baudolino -
Dries
-
drumm
-
jhriggs
-
patryk