Issue status update for http://drupal.org/node/21252 Project: Drupal -Version: cvs +Version: 4.6.0 Component: database system Category: bug reports -Priority: normal +Priority: critical Assigned to: patryk Reported by: patryk Updated by: jhriggs Status: patch I didn't realize the patch had been applied to 4.6 also. Marking as critical. jhriggs Previous comments: ------------------------------------------------------------------------ April 24, 2005 - 20:45 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type-fix.diff (317 bytes) Field "location" in table "locales_source" is too short. The patch makes it limitless. ------------------------------------------------------------------------ April 25, 2005 - 12:55 : Dries There is a similar location-row in the watchdog table. The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL. I wouldn't recommend making it limitless. Maybe 255 is more sensible? ------------------------------------------------------------------------ April 28, 2005 - 15:44 : patryk Attachment: http://drupal.org/files/issues/drupal-cvs-pgsql-locales_field_type_v2-fix.di... (686 bytes) Hmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now. The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here. The new patch attached and bug details changed. ------------------------------------------------------------------------ May 1, 2005 - 11:06 : Dries Committed to HEAD and DRUPAL-4-6. Thanks patryk. ------------------------------------------------------------------------ May 2, 2005 - 10:43 : jhriggs The field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached. Note: Shouldn't there also be a update in updates.inc for this since it is a schema change?