Issue status update for http://drupal.org/node/18068 Project: Drupal Version: 4.5.0 Component: node.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: elonen Updated by: Bèr Kessels Status: patch -1 from me. IMO the amount of feed-items should be the same as the amount of items on the frontpage. So instead of hardcoded fifteen, we should use variable_get('default_nodes_main', 10). That way we do not need another setting, and we have consistancy. Bèr Bèr Kessels Previous comments: ------------------------------------------------------------------------ February 27, 2005 - 19:32 : elonen Attachment: http://drupal.org/files/issues/rss-date-and-len.diff (3.25 KB) Using modification date in pubDate is suboptimal if you just want to promote new content, not updates. Also, 15 is too small maximum for RSS item count in some cases. This patch against 4.5. adds an option for changing these defaults. (It would be even better if the admin/users could create custom feeds but that'd be a much bigger change.) ------------------------------------------------------------------------ February 28, 2005 - 14:42 : Bèr Kessels -1 from me. IMO the amount of feed-items should be the same as the amount of items on the frontpage. So instead of hardcoded fifteen, we should use variable_get('default_nodes_main', 10). That way we do not need another setting, and we have consistancy. Bèr

Issue status update for http://drupal.org/node/18068 Project: Drupal Version: 4.5.0 Component: node.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: elonen Updated by: Morbus Iff Status: patch I disagree with Ber (it's called "default_nodes_main", not "default_nodes_main_and_rss") and agree with elonen. We shouldn't overload one setting in the name of "now we don't need another option, WHEee!". I'd rather let the feature request die then misconstrue the intent of a preference. With that said, I'm also -1ing the patch. The chosen preference names are horrible (I'd rather see "default_nodes_feed"), the preference options aren't friendly ("what the hell is a feed?" - even the addition of "syndication" somewhere would be better), and the help explanation for the dates is far too confusing. Morbus Iff Previous comments: ------------------------------------------------------------------------ February 27, 2005 - 13:32 : elonen Attachment: http://drupal.org/files/issues/rss-date-and-len.diff (3.25 KB) Using modification date in pubDate is suboptimal if you just want to promote new content, not updates. Also, 15 is too small maximum for RSS item count in some cases. This patch against 4.5. adds an option for changing these defaults. (It would be even better if the admin/users could create custom feeds but that'd be a much bigger change.) ------------------------------------------------------------------------ February 28, 2005 - 08:42 : Bèr Kessels -1 from me. IMO the amount of feed-items should be the same as the amount of items on the frontpage. So instead of hardcoded fifteen, we should use variable_get('default_nodes_main', 10). That way we do not need another setting, and we have consistancy. Bèr ------------------------------------------------------------------------ February 28, 2005 - 08:43 : Bèr Kessels -1 from me. IMO the amount of feed-items should be the same as the amount of items on the frontpage. So instead of hardcoded fifteen, we should use variable_get('default_nodes_main', 10). That way we do not need another setting, and we have consistancy. Bèr ------------------------------------------------------------------------ February 28, 2005 - 08:58 : elonen The RSS stream and the front page are two completely different views. For example, they both take different amounts of screen space when viewed by a human and the RSS is often used for programmatic syndication, for which the front page listing may be too short (this is the case in my system). My point is: different purpose => different configuration.