[drupal-devel] first commit - image_url_filter module
Hi, I have just added a small filter module 'image_url_filter'. http://cvs.drupal.org/viewcvs/drupal/contributions/modules/image_url_filter/ Since it is my first contribution, it is intentionally a small and trivial one. I would appreciate it if other people would give it a good look over to make sure that I am doing things OK (while I find my feet as a Drupal developer). Thanks, Ross (rkendall) P.S. Here's what the README.txt says: This is a simple filter module. It automatically converts URLs ending with .png .gif .jpg and .jpeg into <img> html tags, so the image is displayed on the page (http/https only). Apparently Wiki's use a filter like this, I got the idea from someone's suggestion here: http://drupal.org/node/15877#comment-28600
Hi, Its a nice and small module. But I beleive you should really integrate this with another module. TRy adding it as a separate filter to urlfilter.module. That way tracking bugs will be easier. But also people will find it much easier to find. Bèr Op vrijdag 25 februari 2005 15:23, schreef Ross Kendall:
Hi,
I have just added a small filter module 'image_url_filter'. http://cvs.drupal.org/viewcvs/drupal/contributions/modules/image_url_filter /
Since it is my first contribution, it is intentionally a small and trivial one.
I would appreciate it if other people would give it a good look over to make sure that I am doing things OK (while I find my feet as a Drupal developer).
Thanks, Ross (rkendall)
P.S. Here's what the README.txt says: This is a simple filter module. It automatically converts URLs ending with .png .gif .jpg and .jpeg into <img> html tags, so the image is displayed on the page (http/https only).
Apparently Wiki's use a filter like this, I got the idea from someone's suggestion here: http://drupal.org/node/15877#comment-28600 Regards, Bèr -- [ Bèr Kessels | Drupal services www.webschuur.com ]
Bèr, Thanks for taking the time to have a look (no one else did). Your suggestion makes sense, so I will have a look at a patch for urlfilter.module. I was expecting a comment like this, that's why I didn't add it as a project. Cheers, Ross. Bèr Kessels wrote:
Hi,
Its a nice and small module. But I beleive you should really integrate this with another module. TRy adding it as a separate filter to urlfilter.module. That way tracking bugs will be easier. But also people will find it much easier to find.
Bèr
Op vrijdag 25 februari 2005 15:23, schreef Ross Kendall:
Hi,
I have just added a small filter module 'image_url_filter'. http://cvs.drupal.org/viewcvs/drupal/contributions/modules/image_url_filter /
Since it is my first contribution, it is intentionally a small and trivial one.
I would appreciate it if other people would give it a good look over to make sure that I am doing things OK (while I find my feet as a Drupal developer).
Thanks, Ross (rkendall)
P.S. Here's what the README.txt says: This is a simple filter module. It automatically converts URLs ending with .png .gif .jpg and .jpeg into <img> html tags, so the image is displayed on the page (http/https only).
Apparently Wiki's use a filter like this, I got the idea from someone's suggestion here: http://drupal.org/node/15877#comment-28600
Regards, Bèr
participants (2)
-
Bèr Kessels -
Ross Kendall