Giving credit for committed patches
I'm about to talk about a potentially sensitive subject. I will try to approach this delicately by first saying this is not an attach or criticism, just a suggestion for improvement. It is not my intention to start a flame war as has been suggested. So with that out tof the way, I was noticing the other day that Dries gives credit to patch contributors in the cvs log message. I think this is smart. First, it helps build the reputation of those who contribute, garnering them the good will of the community, second it strokes their ego. As far as building the reputation of contributors, I think we all recognize that this is an extremely important facet of open source development. For most of us, our reputation within the Drupal community is dependent upon the letters in our respective handles. When I see the letters m-e-r-l-i-n-o-f-c-h-a-o-s I think happy thoughts. He's helped me tremendously and I can him credit because the things he has done for me have come from those mysterious arrangement of letters. And I have done what I can to reward him for his efforts. So I think when we give credit to contributors and build their reputation, it spreads good will. And it puts a human face to the code many labor so hard on. Second, let's just all admit right now we have egos. I'll be the first to say that, yup, I have one. No, I don't work just to receive recognition and praise for others. Just the challenge of programming and and building web sites for worthwhile cause provides enough self-fulfillment for me to carry on. That said, it sure does feel good when I get some recognition. When my first bug fix patch hit the Drupal core, I feld some accomplishment. And when I saw my name associated with that patch, I was quite proud and got a little high from it. It was the first open source project I was able to contribute to. On the other hand, I also feel a bit sleighted when I contriubute some time or talent to a project (on any endeavor, not just Drupal), and no one takes the the time to say "thanks". That doesn't mean I stop doing the work, but it does mean that I'm less motivated to do something next time. I feel a bit used. Maybe I'm an anomaly and I'm just a big egotistical asshole. But I suspect I'm just any other human and simply like getting recognition, no matter how small. So, my suggestion is to simply make more of attempt to give credit to those who contributed their time and talent in the cvs log messages. I think the effort expended to do that is minimal (maybe Dries can better respond to this point) and well worth the effort by fostering more good will and good vibes in the development community.
On 03 Mar 2006, at 8:13 PM, Steve Dondley wrote:
I'm about to talk about a potentially sensitive subject. I will try to approach this delicately by first saying this is not an attach or criticism, just a suggestion for improvement. It is not my intention to start a flame war as has been suggested.
I will stab the person who says 'bzr' first in the face. -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com
On 03 Mar 2006, at 8:23 PM, Earl Miles wrote:
Adrian Rossouw wrote:
I will stab the person who says 'bzr' first in the face.
bzr Don't make me turn this car around young man. =)
-- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com
Adrian Rossouw wrote:
Don't make me turn this car around young man. =)
I may spend the rest of the day going 'bzr. bzr! BZR!!!' to myself, now. It may be a sign of senility, but more likely it's a sign of a really bad sense of humor.
On 03 Mar 2006, at 8:13 PM, Steve Dondley wrote:
I'm about to talk about a potentially sensitive subject. I will try to approach this delicately by first saying this is not an attach or criticism, just a suggestion for improvement. It is not my intention to start a flame war as has been suggested. umm..
that last mail was in jest. really. but seriously. please don't hijack this into a Drupal should switch to bzr thread. -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com
Part of the issue is that commits are linked automatically with who did them but not with who might have contributed the code (yes, a characteristic of the CVS system). But we could add some linking functionality--a convention for linking to users in CVS commit messages like we currently have for linking to issues using the # sign. Accordingly, I've created this issue on the cvs module: http://drupal.org/node/52285
But we could add some linking functionality--a convention for linking to users in CVS commit messages like we currently have for linking to issues using the # sign.
I don't think this is the core issue - I think the core issue is that a few commiters aren't putting the names in the commit messages, so there'd be nothing to actually link. -- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ O'Reilly Author, Weblog, Cook: http://www.oreillynet.com/pub/au/779 icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus
Well, you can just put a link where possible. On 3/3/06, Morbus Iff <morbus@disobey.com> wrote:
But we could add some linking functionality--a convention for linking to users in CVS commit messages like we currently have for linking to issues using the # sign.
I don't think this is the core issue - I think the core issue is that a few commiters aren't putting the names in the commit messages, so there'd be nothing to actually link.
-- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ O'Reilly Author, Weblog, Cook: http://www.oreillynet.com/pub/au/779 icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus
-- Dondley Communications http://www.dondleycommunications.com Communicate or Die: American Labor Unions and the Internet http://www.communicateordie.com
I don't think this is the core issue - I think the core issue is that a few commiters aren't putting the names in the commit messages, so there'd be nothing to actually link.
Well, but changed systems may help produce changed habits. We may be more likely to take the extra time to give credit when we know it will be more visible. Added a handbook page on commit messages, including the importance of giving credit: http://drupal.org/node/52287
On Fri, 2006-03-03 at 13:13 -0500, Steve Dondley wrote: <snip>
So, my suggestion is to simply make more of attempt to give credit to those who contributed their time and talent in the cvs log messages. I think the effort expended to do that is minimal (maybe Dries can better respond to this point) and well worth the effort by fostering more good will and good vibes in the development community.
Beyond just recognition, it also enables us to find who authored certain pieces of code and ask them, why did you do x, is there a reason you didn't do y?
Beyond just recognition, it also enables us to find who authored certain pieces of code and ask them, why did you do x, is there a reason you
And this is different from looking at the issue nid how? -- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ O'Reilly Author, Weblog, Cook: http://www.oreillynet.com/pub/au/779 icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus
And this is different from looking at the issue nid how?
It's not different. But let's not lose site of the fact that it's not realistic to get a feel for who contributed what by visiting the patch discussion for each patch. Generally those are never looked at again except when trying to determine the motivation behind hte patch. With the cvs commit messages, you can tell who contributed at a glance.
Why not append users with @username, just like we do with #nodenumbers? eg:. ---- Fixed #51384. Thanks @gordon ---- Looks geeky, but this makes things reliably linkable, and lookupable, (Also: http://drupal.org/node/52287 "Commit messages--providing history and credit") -Arnab On 3/3/06, Steve Dondley <sdondley@gmail.com> wrote:
And this is different from looking at the issue nid how?
It's not different.
But let's not lose site of the fact that it's not realistic to get a feel for who contributed what by visiting the patch discussion for each patch. Generally those are never looked at again except when trying to determine the motivation behind hte patch.
With the cvs commit messages, you can tell who contributed at a glance.
Do all new features or modules necessarily have an issue nid attached to them? Did the Form API? On Fri, 2006-03-03 at 16:05 -0500, Morbus Iff wrote:
Beyond just recognition, it also enables us to find who authored certain pieces of code and ask them, why did you do x, is there a reason you
And this is different from looking at the issue nid how?
participants (7)
-
Adrian Rossouw -
Arnab Nandi -
Darrel O'Pry -
Earl Miles -
Morbus Iff -
Nedjo Rogers -
Steve Dondley