[drupal-devel] [feature] introduce filapi hook
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: 4.5.2 Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr Bèr Kessels
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: 4.5.2 Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: walkah Status: patch +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) walkah Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 11:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: 4.5.2 Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* Bèr Kessels Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 17:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 18:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?)
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: 4.5.2 Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: robertDouglass Status: patch James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. robertDouglass Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 18:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 19:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 20:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush*
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: 4.5.2 Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: javanaut Status: patch I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). javanaut Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 10:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 11:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 12:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 12:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems.
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: 4.5.2 Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: robertDouglass Status: patch Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. robertDouglass Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 17:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 18:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 19:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 19:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 22:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi().
Issue status update for http://drupal.org/node/18934 Project: Drupal -Version: 4.5.2 +Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: robertDouglass Status: patch Changed version to cvs robertDouglass Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 17:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 18:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 19:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 19:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 22:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ March 23, 2005 - 07:44 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location.
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: Amazon Status: patch +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran Amazon Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 16:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 17:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 18:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 18:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 21:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ March 23, 2005 - 06:44 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ March 23, 2005 - 06:44 : robertDouglass Changed version to cvs
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: JonBob Status: patch Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. JonBob Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 11:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 12:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 13:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 13:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 16:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ March 23, 2005 - 01:44 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ March 23, 2005 - 01:44 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ March 28, 2005 - 17:39 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: robertDouglass Status: patch Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. robertDouglass Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 17:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 18:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 19:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 19:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 22:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ March 23, 2005 - 07:44 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ March 23, 2005 - 07:44 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ March 28, 2005 - 23:39 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ March 28, 2005 - 23:52 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is.
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: joshk Status: patch This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. joshk Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 16:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 17:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 18:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 18:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 21:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ March 23, 2005 - 06:44 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ March 23, 2005 - 06:44 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ March 28, 2005 - 22:39 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ March 28, 2005 - 22:52 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ March 29, 2005 - 08:41 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file.
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: moshe weitzman Status: patch i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core. moshe weitzman Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 11:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 12:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 13:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 13:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 16:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ March 23, 2005 - 01:44 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ March 23, 2005 - 01:44 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ March 28, 2005 - 17:39 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ March 28, 2005 - 17:52 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ March 29, 2005 - 03:41 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ March 29, 2005 - 11:54 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration.
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: chx Status: patch another +1 I think, in general, the more hooks, the better. Most time is consumed by SQL queries and file loading after all, so a few php function calls are not big deal. chx Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 17:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 18:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 19:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 19:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 22:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ March 23, 2005 - 07:44 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ March 23, 2005 - 07:44 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ March 28, 2005 - 23:39 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ March 28, 2005 - 23:52 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ March 29, 2005 - 09:41 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ March 29, 2005 - 17:54 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. ------------------------------------------------------------------------ April 5, 2005 - 16:41 : moshe weitzman i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core.
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: killes@www.drop.org Status: patch I also like this patch. It will make the revisioning of files easier. Currently, I have to keep the nid column in some tables. I can remove that after the patch has landed and rely on vid only. killes@www.drop.org Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 17:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 18:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 19:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 19:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 22:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ March 23, 2005 - 07:44 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ March 23, 2005 - 07:44 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ March 28, 2005 - 23:39 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ March 28, 2005 - 23:52 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ March 29, 2005 - 09:41 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ March 29, 2005 - 17:54 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. ------------------------------------------------------------------------ April 5, 2005 - 16:41 : moshe weitzman i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core. ------------------------------------------------------------------------ April 5, 2005 - 17:41 : chx another +1 I think, in general, the more hooks, the better. Most time is consumed by SQL queries and file loading after all, so a few php function calls are not big deal.
Issue status update for http://drupal.org/node/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: moshe weitzman Status: patch still applies cleanly ... seems like a a handy enhancement to me as well. moshe weitzman Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 11:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 12:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 13:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 13:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ March 15, 2005 - 16:12 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ March 23, 2005 - 01:44 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ March 23, 2005 - 01:44 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ March 28, 2005 - 17:39 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ March 28, 2005 - 17:52 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ March 29, 2005 - 03:41 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ March 29, 2005 - 11:54 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. ------------------------------------------------------------------------ April 5, 2005 - 10:41 : moshe weitzman i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core. ------------------------------------------------------------------------ April 5, 2005 - 11:41 : chx another +1 I think, in general, the more hooks, the better. Most time is consumed by SQL queries and file loading after all, so a few php function calls are not big deal. ------------------------------------------------------------------------ April 5, 2005 - 11:45 : killes@www.drop.org I also like this patch. It will make the revisioning of files easier. Currently, I have to keep the nid column in some tables. I can remove that after the patch has landed and rely on vid only.
Issue status update for http://drupal.org/node/18934 Post a follow up: http://drupal.org/project/comments/add/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: Bèr Kessels -Status: patch (code needs review) +Status: patch (ready to be committed) Patch still applies. with a little fuzzyness (1 or 2 lines). Bèr Kessels Previous comments: ------------------------------------------------------------------------ Tue, 15 Mar 2005 16:15:30 +0000 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ Tue, 15 Mar 2005 17:01:40 +0000 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:00:33 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:34:30 +0000 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ Tue, 15 Mar 2005 21:12:56 +0000 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:06 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:56 +0000 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:39:56 +0000 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:52:24 +0000 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ Tue, 29 Mar 2005 08:41:08 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ Tue, 29 Mar 2005 16:54:26 +0000 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. ------------------------------------------------------------------------ Tue, 05 Apr 2005 15:41:21 +0000 : moshe weitzman i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:41:19 +0000 : chx another +1 I think, in general, the more hooks, the better. Most time is consumed by SQL queries and file loading after all, so a few php function calls are not big deal. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:45:46 +0000 : killes@www.drop.org I also like this patch. It will make the revisioning of files easier. Currently, I have to keep the nid column in some tables. I can remove that after the patch has landed and rely on vid only. ------------------------------------------------------------------------ Thu, 26 May 2005 00:04:52 +0000 : moshe weitzman still applies cleanly ... seems like a a handy enhancement to me as well.
Issue status update for http://drupal.org/node/18934 Post a follow up: http://drupal.org/project/comments/add/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: Steven -Status: patch (ready to be committed) +Status: patch (code needs review) Shouldn't the validate hook allow the file to be actually validated? Now its return value seems to be unused. It also seems weird to me to tie this hook into upload.module... shouldn't it go into file.inc somewhere, so it can apply to all uploaded files? Steven Previous comments: ------------------------------------------------------------------------ Tue, 15 Mar 2005 16:15:30 +0000 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ Tue, 15 Mar 2005 17:01:40 +0000 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:00:33 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:34:30 +0000 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ Tue, 15 Mar 2005 21:12:56 +0000 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:06 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:56 +0000 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:39:56 +0000 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:52:24 +0000 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ Tue, 29 Mar 2005 08:41:08 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ Tue, 29 Mar 2005 16:54:26 +0000 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. ------------------------------------------------------------------------ Tue, 05 Apr 2005 15:41:21 +0000 : moshe weitzman i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:41:19 +0000 : chx another +1 I think, in general, the more hooks, the better. Most time is consumed by SQL queries and file loading after all, so a few php function calls are not big deal. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:45:46 +0000 : killes@www.drop.org I also like this patch. It will make the revisioning of files easier. Currently, I have to keep the nid column in some tables. I can remove that after the patch has landed and rely on vid only. ------------------------------------------------------------------------ Thu, 26 May 2005 00:04:52 +0000 : moshe weitzman still applies cleanly ... seems like a a handy enhancement to me as well. ------------------------------------------------------------------------ Tue, 02 Aug 2005 18:41:41 +0000 : Bèr Kessels Patch still applies. with a little fuzzyness (1 or 2 lines).
Issue status update for http://drupal.org/node/18934 Post a follow up: http://drupal.org/project/comments/add/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: telex4 Status: patch (code needs review) +1 from me. Drupal is really lacking in the file-handling department at the moment, which is quite a pain for us at Remix Reading since our web site is supposed to support a file-sharing remix community! From what I can see this at least starts to point Drupal in the right direction... telex4 Previous comments: ------------------------------------------------------------------------ Tue, 15 Mar 2005 16:15:30 +0000 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ Tue, 15 Mar 2005 17:01:40 +0000 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:00:33 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:34:30 +0000 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ Tue, 15 Mar 2005 21:12:56 +0000 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:06 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:56 +0000 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:39:56 +0000 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:52:24 +0000 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ Tue, 29 Mar 2005 08:41:08 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ Tue, 29 Mar 2005 16:54:26 +0000 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. ------------------------------------------------------------------------ Tue, 05 Apr 2005 15:41:21 +0000 : moshe weitzman i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:41:19 +0000 : chx another +1 I think, in general, the more hooks, the better. Most time is consumed by SQL queries and file loading after all, so a few php function calls are not big deal. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:45:46 +0000 : killes@www.drop.org I also like this patch. It will make the revisioning of files easier. Currently, I have to keep the nid column in some tables. I can remove that after the patch has landed and rely on vid only. ------------------------------------------------------------------------ Thu, 26 May 2005 00:04:52 +0000 : moshe weitzman still applies cleanly ... seems like a a handy enhancement to me as well. ------------------------------------------------------------------------ Tue, 02 Aug 2005 18:41:41 +0000 : Bèr Kessels Patch still applies. with a little fuzzyness (1 or 2 lines). ------------------------------------------------------------------------ Wed, 17 Aug 2005 01:01:49 +0000 : Steven Shouldn't the validate hook allow the file to be actually validated? Now its return value seems to be unused. It also seems weird to me to tie this hook into upload.module... shouldn't it go into file.inc somewhere, so it can apply to all uploaded files?
Issue status update for http://drupal.org/node/18934 Post a follow up: http://drupal.org/project/comments/add/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: walkah Status: patch (code needs review) ok, let me qualify my previous +1 , I agree with Steven, this should *absolutely* be part of file.inc *not* upload.module - as there are some other important modules that utilise the file api besides upload.module. it will also likely require refactoring file.inc a bit - since you need to accomodate for several "file saving" senarios - file_save_upload, file_save_data (and perhaps file_move and file_copy?) walkah Previous comments: ------------------------------------------------------------------------ Tue, 15 Mar 2005 16:15:30 +0000 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ Tue, 15 Mar 2005 17:01:40 +0000 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:00:33 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:34:30 +0000 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ Tue, 15 Mar 2005 21:12:56 +0000 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:06 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:56 +0000 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:39:56 +0000 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:52:24 +0000 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ Tue, 29 Mar 2005 08:41:08 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ Tue, 29 Mar 2005 16:54:26 +0000 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. ------------------------------------------------------------------------ Tue, 05 Apr 2005 15:41:21 +0000 : moshe weitzman i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:41:19 +0000 : chx another +1 I think, in general, the more hooks, the better. Most time is consumed by SQL queries and file loading after all, so a few php function calls are not big deal. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:45:46 +0000 : killes@www.drop.org I also like this patch. It will make the revisioning of files easier. Currently, I have to keep the nid column in some tables. I can remove that after the patch has landed and rely on vid only. ------------------------------------------------------------------------ Thu, 26 May 2005 00:04:52 +0000 : moshe weitzman still applies cleanly ... seems like a a handy enhancement to me as well. ------------------------------------------------------------------------ Tue, 02 Aug 2005 18:41:41 +0000 : Bèr Kessels Patch still applies. with a little fuzzyness (1 or 2 lines). ------------------------------------------------------------------------ Wed, 17 Aug 2005 01:01:49 +0000 : Steven Shouldn't the validate hook allow the file to be actually validated? Now its return value seems to be unused. It also seems weird to me to tie this hook into upload.module... shouldn't it go into file.inc somewhere, so it can apply to all uploaded files? ------------------------------------------------------------------------ Fri, 02 Sep 2005 15:19:57 +0000 : telex4 +1 from me. Drupal is really lacking in the file-handling department at the moment, which is quite a pain for us at Remix Reading since our web site is supposed to support a file-sharing remix community! From what I can see this at least starts to point Drupal in the right direction...
Issue status update for http://drupal.org/node/18934 Post a follow up: http://drupal.org/project/comments/add/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: Bèr Kessels Updated by: moshe weitzman Status: patch (code needs review) Like nodeapi('validate'), this validate hook has no return value. Modules are encouraged to form_set_error() if they want to. This will stop the node validation automatically. I think this is a non issue. As for hooking into the file API directly, I think I agree. I asked walkah and robert to comment here on this since they are more familiar with file.inc. -moshe moshe weitzman Previous comments: ------------------------------------------------------------------------ Tue, 15 Mar 2005 16:15:30 +0000 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ Tue, 15 Mar 2005 17:01:40 +0000 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:00:33 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:34:30 +0000 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ Tue, 15 Mar 2005 21:12:56 +0000 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:06 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:56 +0000 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:39:56 +0000 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:52:24 +0000 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ Tue, 29 Mar 2005 08:41:08 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ Tue, 29 Mar 2005 16:54:26 +0000 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. ------------------------------------------------------------------------ Tue, 05 Apr 2005 15:41:21 +0000 : moshe weitzman i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:41:19 +0000 : chx another +1 I think, in general, the more hooks, the better. Most time is consumed by SQL queries and file loading after all, so a few php function calls are not big deal. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:45:46 +0000 : killes@www.drop.org I also like this patch. It will make the revisioning of files easier. Currently, I have to keep the nid column in some tables. I can remove that after the patch has landed and rely on vid only. ------------------------------------------------------------------------ Thu, 26 May 2005 00:04:52 +0000 : moshe weitzman still applies cleanly ... seems like a a handy enhancement to me as well. ------------------------------------------------------------------------ Tue, 02 Aug 2005 18:41:41 +0000 : Bèr Kessels Patch still applies. with a little fuzzyness (1 or 2 lines). ------------------------------------------------------------------------ Wed, 17 Aug 2005 01:01:49 +0000 : Steven Shouldn't the validate hook allow the file to be actually validated? Now its return value seems to be unused. It also seems weird to me to tie this hook into upload.module... shouldn't it go into file.inc somewhere, so it can apply to all uploaded files? ------------------------------------------------------------------------ Fri, 02 Sep 2005 15:19:57 +0000 : telex4 +1 from me. Drupal is really lacking in the file-handling department at the moment, which is quite a pain for us at Remix Reading since our web site is supposed to support a file-sharing remix community! From what I can see this at least starts to point Drupal in the right direction... ------------------------------------------------------------------------ Fri, 02 Sep 2005 15:27:48 +0000 : walkah ok, let me qualify my previous +1 , I agree with Steven, this should *absolutely* be part of file.inc *not* upload.module - as there are some other important modules that utilise the file api besides upload.module. it will also likely require refactoring file.inc a bit - since you need to accomodate for several "file saving" senarios - file_save_upload, file_save_data (and perhaps file_move and file_copy?)
Issue status update for http://drupal.org/node/18934 Post a follow up: http://drupal.org/project/comments/add/18934 Project: Drupal Version: cvs Component: file system Category: feature requests Priority: normal -Assigned to: robertDouglass +Assigned to: Anonymous Reported by: Bèr Kessels Updated by: robertDouglass -Status: patch (code needs review) +Status: patch (code needs work) I would be happy to see file.inc refactored to support this hook, but I remember that at the time I created it, it wasn't possible to add it there (details long ago forgotten). File.inc is the obvious appropriate place, and everyone seems to like the functionality. I can't volunteer to look into this at the moment, however. Unassigning myself. robertDouglass Previous comments: ------------------------------------------------------------------------ Tue, 15 Mar 2005 16:15:30 +0000 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ Tue, 15 Mar 2005 17:01:40 +0000 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:00:33 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ Tue, 15 Mar 2005 18:34:30 +0000 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems. ------------------------------------------------------------------------ Tue, 15 Mar 2005 21:12:56 +0000 : javanaut I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:06 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_0.txt (2.46 KB) Added validate hook (2 lines). Please verify if this looks like the best choice of location. ------------------------------------------------------------------------ Wed, 23 Mar 2005 06:44:56 +0000 : robertDouglass Changed version to cvs ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:39:56 +0000 : Amazon +1 We need this for musicforamerica. We need to allow artists to enter meta data about themselves and their files. Also, we want to be able to allow for encoding based on the metadata as selected by artists. So on upload we encode a low bitstream for radio. We will also encode at a bitrate the artist allows us to distribute their music. Kieran ------------------------------------------------------------------------ Mon, 28 Mar 2005 22:52:24 +0000 : JonBob Could we call this hook_file() instead? IIRC, I agree with Dries on this matter; the similar hook_user() and hook_taxonomy() constructs are more nicely named than hook_nodeapi() is. ------------------------------------------------------------------------ Tue, 29 Mar 2005 08:41:08 +0000 : robertDouglass Attachment: http://drupal.org/files/issues/upload.module.patch_1.txt (2.44 KB) Sure! It is now hook_file. ------------------------------------------------------------------------ Tue, 29 Mar 2005 16:54:26 +0000 : joshk This will be useful for a whole lot of things going forward. Another example this would help drive is bittorrent integration. ------------------------------------------------------------------------ Tue, 05 Apr 2005 15:41:21 +0000 : moshe weitzman i'll add to the chorus that this is a useful, minimally invasive patch. very drupalish. would be nice to run media.module without needing to patch core. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:41:19 +0000 : chx another +1 I think, in general, the more hooks, the better. Most time is consumed by SQL queries and file loading after all, so a few php function calls are not big deal. ------------------------------------------------------------------------ Tue, 05 Apr 2005 16:45:46 +0000 : killes@www.drop.org I also like this patch. It will make the revisioning of files easier. Currently, I have to keep the nid column in some tables. I can remove that after the patch has landed and rely on vid only. ------------------------------------------------------------------------ Thu, 26 May 2005 00:04:52 +0000 : moshe weitzman still applies cleanly ... seems like a a handy enhancement to me as well. ------------------------------------------------------------------------ Tue, 02 Aug 2005 18:41:41 +0000 : Bèr Kessels Patch still applies. with a little fuzzyness (1 or 2 lines). ------------------------------------------------------------------------ Wed, 17 Aug 2005 01:01:49 +0000 : Steven Shouldn't the validate hook allow the file to be actually validated? Now its return value seems to be unused. It also seems weird to me to tie this hook into upload.module... shouldn't it go into file.inc somewhere, so it can apply to all uploaded files? ------------------------------------------------------------------------ Fri, 02 Sep 2005 15:19:57 +0000 : telex4 +1 from me. Drupal is really lacking in the file-handling department at the moment, which is quite a pain for us at Remix Reading since our web site is supposed to support a file-sharing remix community! From what I can see this at least starts to point Drupal in the right direction... ------------------------------------------------------------------------ Fri, 02 Sep 2005 15:27:48 +0000 : walkah ok, let me qualify my previous +1 , I agree with Steven, this should *absolutely* be part of file.inc *not* upload.module - as there are some other important modules that utilise the file api besides upload.module. it will also likely require refactoring file.inc a bit - since you need to accomodate for several "file saving" senarios - file_save_upload, file_save_data (and perhaps file_move and file_copy?) ------------------------------------------------------------------------ Fri, 02 Sep 2005 15:28:49 +0000 : moshe weitzman Like nodeapi('validate'), this validate hook has no return value. Modules are encouraged to form_set_error() if they want to. This will stop the node validation automatically. I think this is a non issue. As for hooking into the file API directly, I think I agree. I asked walkah and robert to comment here on this since they are more familiar with file.inc. -moshe
participants (12)
-
Amazon -
Bèr Kessels
-
chx
-
javanaut
-
JonBob
-
joshk
-
killes
-
moshe weitzman
-
robertDouglass
-
Steven
-
telex4
-
walkah