Issue status update for http://drupal.org/node/18934 Project: Drupal Version: 4.5.2 Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: javanaut Status: patch I would suggest adding a "validate" hook in there as well. This would allow for file cleaning modules to be developed (such as virus scanners). This could be placed along with the other validation checks in upload_nodeapi(). javanaut Previous comments: ------------------------------------------------------------------------ March 15, 2005 - 10:15 : Bèr Kessels This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr ------------------------------------------------------------------------ March 15, 2005 - 11:01 : walkah +1 for this idea (even though I don't actually see a patch) . My big concern here is trying to manage the order of operations. particularly when you get into resizing / re-encoding things. i.e. how could we handle multiple modules that want to do generate thumbnails? or multiple bitrates for a media file? overall though, i like the idea alot! (was there actually a patch somewhere?) ------------------------------------------------------------------------ March 15, 2005 - 12:00 : Bèr Kessels Attachment: http://drupal.org/files/issues/upload.module.patch.txt (1.92 KB) forgot the attachement. *blush* ------------------------------------------------------------------------ March 15, 2005 - 12:34 : robertDouglass James, how hard would it be to react to these lifecycle events in your image.module so that any image file that gets uploaded via upload.module gets handled as an image automatically? As to the issue of "competing" interests from various modules on the same events (what you described above), don't we already have that danger in nodeapi? Have we run into any problems there? The things you want to do with files are rather discreet, I can't imagine two modules wanting to read the bitrate of a movie separately. Anyway, thanks Bèr for submitting this patch, I'm looking forward to having people evaluate the idea and help think of possible uses and problems.