why not just phptemplate in core?
Hello, I have one question. Why do we ship a plain PHP theme in core? Wouldn't it be good for consistency if all themes would be a phptemplate theme? and wouldn't it be easier to maintain a phptemplate theme as a plain PHP theme? Is there any reason why chameleon is plain PHP? I think it may confuse people that we ship a theme where the code is not similar compared with all other core themes. cu Tobi btw. I converted the chameleon theme to phptemplate: see http://drupal.org/node/41005
On 02 Jan 2006, at 1:48 AM, Tobias Maier wrote:
Is there any reason why chameleon is plain PHP? historical reasons. politics.
it's incredibly simple to convert and a LOT more useful as a phptemplate theme. It's forward compatible in that all the functions used only need to be changed once. phptemplate is far far better documented.
btw. I converted the chameleon theme to phptemplate: see http://drupal.org/node/41005
-- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com
Tobias Maier wrote:
I think it may confuse people that we ship a theme where the code is not similar compared with all other core themes.
Plain PHP themes are useful. Correct me if I am wrong, but I do not see a way for a PHP template theme to control what features it offers or which block regions are present. As far as I know the only way to control these is in a plain PHP theme. Standardizing on one templating system is okay, and I think PHP template is an excellent choice. But I am not sure that it is ready and I do not want to leave the extra layer of API in place if we do standardize on one templating system. I do think plain PHP themes are here to stay, so lets keep a well-maintained example in core. -- Neil Drumm http://delocalizedham.com/
Op maandag 02 januari 2006 07:59, schreef Neil Drumm:
Standardizing on one templating system is okay, and I think PHP template is an excellent choice. But I am not sure that it is ready and I do not want to leave the extra layer of API in place if we do standardize on one templating system.
For power themes I found pure PHP themes to be the most powerfull. PHPTemplate makes assumptions, which is good for agile development. But its often hard to circumvent these assumptions in your PHPTemplate. And if so, you often have to build another layer on top of the phptemplate templates layer (that means Drupal -> engine -> your_theme -> your_logic). In that latter case a pure php theme is a very god alternative. (drupal -> your_theme_and_logic) But, yes standardising is good (you can focus better, then), but only if that standard is flexible enough to meet all our needs. ATM we do not have that yet, hence I think maintaining the full range of flexibility, as examples, in core, is the best idea. Ber
Neil Drumm wrote:
Tobias Maier wrote:
I think it may confuse people that we ship a theme where the code is not similar compared with all other core themes.
Plain PHP themes are useful. Correct me if I am wrong, but I do not see a way for a PHP template theme to control what features it offers or which block regions are present. As far as I know the only way to control these is in a plain PHP theme.
Standardizing on one templating system is okay, and I think PHP template is an excellent choice. But I am not sure that it is ready and I do not want to leave the extra layer of API in place if we do standardize on one templating system.
I do think plain PHP themes are here to stay, so lets keep a well-maintained example in core.
I second these points. Nothing beats the plain PHP themes in feature set. There used to be different themes in core. There are even only style sheet based themes (named styles), which are not plain PHP nor PHPTemplate. Drupal core should show off the versatile possibilities of the themeing system, and should not give the impression that Drupal is a "one templating system only CMS". Drupal can do more. Goba
Plain PHP themes are useful. Correct me if I am wrong, but I do not see a way for a PHP template theme to control what features it offers or which block regions are present. As far as I know the only way to control these is in a plain PHP theme.
PHP Template can show a specific region anywhere you like. You can do it using flexiblock: http://baheyeldin.com/drupal/drupal-using-flexinode-to-show-hide-adsense.htm... Or using 4.7 regions (which is more tedious). http://baheyeldin.com/drupal/using-drupal-4-7-regions-to-show-hide-adsense.h...
Just to be clear, I am not against multiple ways of theming, specially when they are more flexible and customizable. I was just pointing out something in PHPtemplate. On 1/2/06, Khalid B <kb@2bits.com> wrote:
Plain PHP themes are useful. Correct me if I am wrong, but I do not see a way for a PHP template theme to control what features it offers or which block regions are present. As far as I know the only way to control these is in a plain PHP theme.
PHP Template can show a specific region anywhere you like.
You can do it using flexiblock: http://baheyeldin.com/drupal/drupal-using-flexinode-to-show-hide-adsense.htm...
Or using 4.7 regions (which is more tedious). http://baheyeldin.com/drupal/using-drupal-4-7-regions-to-show-hide-adsense.h...
Hi Tobias, I think the Chameleon theme is valuable for people who want to understand how "Real Drupal Theming" works. This is an important skill for people who want to either make new engines or make non-HTML themes. I think there are still a lot of people who choose it over PHPTemplate based themes for performance reasons as well (I know Goba does). So it seems to have its place in core. cheers, Robert Tobias Maier wrote:
Hello,
I have one question. Why do we ship a plain PHP theme in core? Wouldn't it be good for consistency if all themes would be a phptemplate theme? and wouldn't it be easier to maintain a phptemplate theme as a plain PHP theme? Is there any reason why chameleon is plain PHP?
I think it may confuse people that we ship a theme where the code is not similar compared with all other core themes.
cu Tobi
btw. I converted the chameleon theme to phptemplate: see http://drupal.org/node/41005
Hi everyone, I'm not a search guru, but if I'm correct, I think there is a serious bug in 4.6.* search that renders the search engine far less useful than it should be. If correct, this patch would be an easy win in improving 4.6 search. http://drupal.org/node/43022 cheers, Robert
participants (7)
-
Adrian Rossouw -
Bèr Kessels -
Gabor Hojtsy -
Khalid B -
Neil Drumm -
Robert Douglass -
Tobias Maier