Some issues and their fixes with Drupal 4.6.6 and PostgreSQL
Hello All, We ran into few issues when running Drupal 4.6.6 with PostgreSQL. The issue, in general, seems to be with some queries in some of the modules that attempted to insert a blank string ('') into an integer field. The modules affected are: user.module and node.module from Drupal Core, and flexinode module. I found that this issue has been discussed already at http://drupal.org/node/27870. I have a patch that fixes this issue reasonably. Please let me know how I should go about contributing it. Perhaps I could post the patch somewhere - either on this list or on one of the forums on drupal.org - and then one of the contributors can propagate it to the source code. Also, what is best place to post a patch for the fix in flexinode module? Thanks, Nimish
Hello Nimish It is unlikely that bug fixes against 4.6.x would be accepted, simply because we try to restrict fixes to stable releases to secruity fixes only. However, you can always file a bug by registering for an account at drupal.org and then creating an issue against the below mentioned modules and attaching a patch in unidiff format (read the Drupal Handbook for more details on how to create patches). More importantly, you should check if the latest 4.7 release candidate has the same problem, and submit a patch for that. 4.7 is around the corner, and we need all the fixes we can for it. Thanks and regards. On 4/19/06, Nimish Pachapurkar <npac@spikesource.com> wrote:
Hello All,
We ran into few issues when running Drupal 4.6.6 with PostgreSQL. The issue, in general, seems to be with some queries in some of the modules that attempted to insert a blank string ('') into an integer field.
The modules affected are: user.module and node.module from Drupal Core, and flexinode module.
I found that this issue has been discussed already at http://drupal.org/node/27870.
I have a patch that fixes this issue reasonably. Please let me know how I should go about contributing it. Perhaps I could post the patch somewhere - either on this list or on one of the forums on drupal.org - and then one of the contributors can propagate it to the source code.
Also, what is best place to post a patch for the fix in flexinode module?
Thanks, Nimish
On 19-Apr-06, at 6:11 PM, Khalid B wrote:
It is unlikely that bug fixes against 4.6.x would be accepted, simply because we try to restrict fixes to stable releases to secruity fixes only.
Which is kind of interesting. And we might want to revisit. I mean, if Postgres is supposed to work in core, and doesn't...well, kind of should be fixed, right? We should re-open this discussion once 4.7 is shipped. -- Boris
Boris Mann wrote:
On 19-Apr-06, at 6:11 PM, Khalid B wrote:
It is unlikely that bug fixes against 4.6.x would be accepted, simply because we try to restrict fixes to stable releases to secruity fixes only.
Which is kind of interesting. And we might want to revisit. I mean, if Postgres is supposed to work in core, and doesn't...well, kind of should be fixed, right?
Right. Fixes to the stable branch have been comitted in the past, but our ressources were simply stretched too far to do it in a consistent manner.
We should re-open this discussion once 4.7 is shipped.
The 4.7 branch comes with a dedicated maintainer. Cheers, Gerhard
"Boris Mann" wrote:
On 19-Apr-06, at 6:11 PM, Khalid B wrote:
It is unlikely that bug fixes against 4.6.x would be accepted, simply because we try to restrict fixes to stable releases to secruity fixes only.
Which is kind of interesting. And we might want to revisit. I mean, if Postgres is supposed to work in core, and doesn't...well, kind of should be fixed, right?
I was under the impression that, once bugs piled up, a new version was envisioned and everyone just moved on. :) There really are serious bugs that are more than a year (or more) old. (We are only 3 people, and although we've hammered out a few issues, we can not address the whole of Drupal and still complete our own work.) There are even bugs listed as fixed when they clearly are not (see Project Module, for example.) (Bugs marked as 'fixed' and 'patch applied' are not propagated to the actual code, in this case.) And these will likely just get "moved over" to 4.7, bug-intact. The number one concern in our Tuesday meeting, (from last week), was this: We can not move any client to 4.7 because it's not a release, yet. We can not move any client to 4.7 because dependencies aren't ported. We can not add more clients with 4.6.6 because there is no support, and outstanding bug issues languish in 'who cares' land. We can not add more clients using CivicSpace 0.8.x, because that's built on 4.6.6, and the loop repeats. If we continue to devote all our time to fixing problems in the underlying software, then how can we continue to get to the actual work of helping clients communicate within their community? There is mounting pressure on the 3 of us who do the daily work to find a system where there is a clear development pattern and reliable sources of support (the Drupal web site is quite the mess.) This upsets us, because we've devoted quite a few months to "learn Drupal", and our joy at finding it is turning to concern over our strong advocacy. [Admittedly, we did not do all of our own homework, and we came out strongly for something that we didn't understand was in such a state of flux. That's our problem, and not Drupal at all.] So, if "no bugs for 4.6" will be fixed, and there is not a subsequent version yet that is not built on 4.6, then what would you have users conclude? It is not hard to conclude that Drupal development shares some characteristics with the DSM-IV-R definition of Attention Deficit Disorder. Drupal, at this point, is a developers-only prospect. I think that should be made more clear to noobs who want a CMS, but have no idea where to find 'front page module', let alone edit that module's code. Prediction: Version 5.5 will be useful to non-PHP programmers. Prediction: Adoption of 4.7 will be as slow as molasses in January. -- Gary
Gary (Lists) wrote:
"Boris Mann" wrote:
On 19-Apr-06, at 6:11 PM, Khalid B wrote:
It is unlikely that bug fixes against 4.6.x would be accepted, simply because we try to restrict fixes to stable releases to secruity fixes only.
Which is kind of interesting. And we might want to revisit. I mean, if Postgres is supposed to work in core, and doesn't...well, kind of should be fixed, right?
I was under the impression that, once bugs piled up, a new version was envisioned and everyone just moved on. :)
There really are serious bugs that are more than a year (or more) old. (We are only 3 people, and although we've hammered out a few issues, we can not address the whole of Drupal and still complete our own work.)
If they were all that serious we'd have had fixes by now.
There are even bugs listed as fixed when they clearly are not (see Project Module, for example.) (Bugs marked as 'fixed' and 'patch applied' are not propagated to the actual code, in this case.) And these will likely just get "moved over" to 4.7, bug-intact.
Then be so kind and re-open them.
The number one concern in our Tuesday meeting, (from last week), was this:
Whose Tuesday meeting?
We can not move any client to 4.7 because it's not a release, yet. We can not move any client to 4.7 because dependencies aren't ported.
We can not add more clients with 4.6.6 because there is no support, and outstanding bug issues languish in 'who cares' land.
We can not add more clients using CivicSpace 0.8.x, because that's built on 4.6.6, and the loop repeats.
If we continue to devote all our time to fixing problems in the underlying software, then how can we continue to get to the actual work of helping clients communicate within their community?
Why do you think the subscribers of this mailing list should remotely care about the needs of your clients? or your needs? How many patches have you sent? How many patches reviewed? How many contrib modules ported to 4.7?
There is mounting pressure on the 3 of us who do the daily work to find a system where there is a clear development pattern and reliable sources of support (the Drupal web site is quite the mess.) This upsets us, because
Then do me the favour and leave. Now. I am really fed up with people making money from Drupal and not contributing back but by whining. Get lost. All of you. Now. Cheers, Gerhard
There is mounting pressure on the 3 of us who do the daily work to find a system where there is a clear development pattern and reliable sources of support (the Drupal web site is quite the mess.) This upsets us, because
Then do me the favour and leave. Now.
I am really fed up with people making money from Drupal and not contributing back but by whining. Get lost. All of you. Now.
Killes: On the expectation of free support, I prefer Chris Johnson's tactful response. Gary: I respectfully suggest that your group reconsider the cost of doing business. As Chris described[1], the primary options are to pay someone else for support or to devote resources for internal support. Both options incur non-zero costs, but I hope you will find that Drupal is attractive and cost-effective. "There is no free lunch." Nic Ivy ----- [1] See the "Getting to know Drupal" video interview at http:// drupal.org/node/50477, 2nd video, starting at 17:15.
Nic Ivy wrote:
There is mounting pressure on the 3 of us who do the daily work to find a system where there is a clear development pattern and reliable sources of support (the Drupal web site is quite the mess.) This upsets us, because
Then do me the favour and leave. Now.
I am really fed up with people making money from Drupal and not contributing back but by whining. Get lost. All of you. Now.
Killes: On the expectation of free support, I prefer Chris Johnson's tactful response.
It's a free country, you are allowed to do so. I obviously prefer my version, otherwise I hadn't written it. The original version was actually much better, but would have made people blush.
Gary: I respectfully suggest that your group reconsider the cost of doing business. As Chris described[1], the primary options are to pay someone else for support or to devote resources for internal support. Both options incur non-zero costs, but I hope you will find that Drupal is attractive and cost-effective. "There is no free lunch."
I sincerely hope that people finally get this message. Cheers, Gerhard
"Gerhard Killesreiter" wrote:
I sincerely hope that people finally get this message.
One more thing, Mr. Drupal, before I unsub here (at your request)... I think the message that you are communicating here is quite counter to any spirit of community, which is what you claim that you hope to foster (a community of open-source contributors.) You obviously are a young guy (I'm not, so much) and that's fine. But, in the actual real world, in order to encourage contribution, there is a requirement that you create the conditions for contribution. Those conditions include the possibility of dissent. So far, as I've been subscribed to these lists for only a short time, what I've seen is a group of folks who believe they "are" Drupal. (And, of course, a confused guy -- me -- who doesn't understand how things like Documentation got left by the wayside.) To my ears, your reply is indicative of youth, fear and self-doubt. We have made no money from Drupal. In fact, quite the opposite. The possibility that we spotted has turned into a morass of lost time, wasted effort and rude-boy politics. That's our fault, not yours. It takes time to find, fix and prepare a distributed patch. It's pretty easy to hack away and get something working, but that's not a patch. That takes a little more time. [1] I doubt very seriously that your attitude is inspiring to anyone. The mixed message is this: "Contribute and then shut up." That's a hard sell. But hey, it's your game. -- Gary [1] And from the plethora of submitted patches marked 'Fixed' or 'Committed', when they actually are not fixed or committed, it's no wonder why folks don't take the time to prepare something that is publicly distributable -- why bother is the message. One only has to take a stroll through the Drupal website to read the level of general frustration. Yet, it's easy to dismiss that as "well, they don't write code, so screw them." The problem with that is you build a cumulative tide of discontent. A tide that I see you are surfing with glee.
Hi, I'm the postgresql maintainer, so this concerns me somehow ;) Unfortunatelly I can't read whole thread now, I'll try to do that evening/tommorow. Only small reply now. On Thu, Apr 20, 2006 at 11:01:30AM -0400, Gary (Lists) wrote:
"Gerhard Killesreiter" wrote:
I sincerely hope that people finally get this message.
One more thing, Mr. Drupal, before I unsub here (at your request)...
Killes != Mr. Drupal. He, as anyone, can have his own opinion. I for example don't see such strong response. I appreciate your bug reports/fixes etc. Not that I have time to process them all, but it's better to have a patch that not having any, right?
You obviously are a young guy (I'm not, so much) and that's fine. But, in
IIRC he's not ;)
[1] And from the plethora of submitted patches marked 'Fixed' or 'Committed', when they actually are not fixed or committed, it's no wonder
Are you sure they are not fixed in 4.7/cvs? [BCC to the author] -- Piotrek irc: #debian.pl Mors Drosophilis melanogastribus!
Gary (Lists) wrote:
"Gerhard Killesreiter" wrote:
I sincerely hope that people finally get this message.
One more thing, Mr. Drupal, before I unsub here (at your request)...
I'll gladly help along, should you not find the right button.
I think the message that you are communicating here is quite counter to any spirit of community, which is what you claim that you hope to foster (a community of open-source contributors.)
It is?
You obviously are a young guy (I'm not, so much) and that's fine. But, in
I wish I were.
the actual real world, in order to encourage contribution, there is a requirement that you create the conditions for contribution. Those conditions include the possibility of dissent.
You can dissent all day and I still won't care. What I care about is making unreasonable demands such as me or the Drupal developers being responsible for the happiness of your clients or yourself.
So far, as I've been subscribed to these lists for only a short time, what
Timespans are very relative...
I've seen is a group of folks who believe they "are" Drupal. (And, of course, a confused guy -- me -- who doesn't understand how things like Documentation got left by the wayside.)
These people are usually called developers. Hence the address and byline of this list. People concerned with the documentation are found on the documentation list. http://lists.drupal.org/listinfo/documentation Maybe you want to subscribe and insult them a bit by repeating above statement.
To my ears, your reply is indicative of youth, fear and self-doubt.
That's a good one. Really. I am not young anymore, ok, I don't like horror movies, but I don't know what self-doubt is.
We have made no money from Drupal. In fact, quite the opposite. The possibility that we spotted has turned into a morass of lost time, wasted effort and rude-boy politics. That's our fault, not yours.
If you have clients and don't make money from them, then it really is your fault.
It takes time to find, fix and prepare a distributed patch. It's pretty easy
Don't tell _me_.
to hack away and get something working, but that's not a patch. That takes a little more time. [1]
I doubt very seriously that your attitude is inspiring to anyone.
Well, frankly, I don't know. But I am very sure that anybody who has contributed to a free software project does hate your attitude with a passion.
The mixed message is this:
"Contribute and then shut up."
That's a hard sell.
Anybody who read my mail like this is welcome to read it again. The message is more like "contribute or stfu". At least that was the intended message.
But hey, it's your game.
And I am even good at it.
-- Gary
[1] And from the plethora of submitted patches marked 'Fixed' or 'Committed', when they actually are not fixed or committed, it's no wonder why folks don't take the time to prepare something that is publicly distributable -- why bother is the message.
I dare you to provide proof of the existence of any such patches in Drupal core. Contrib modules are the responsibility of the individual maintainers.
One only has to take a stroll through the Drupal website to read the level of general frustration. Yet, it's easy to dismiss that as "well, they don't write code, so screw them." The problem with that is you build a cumulative tide of discontent.
And even if that were true (I consider it at least an unfair interpretation) why should I care?
A tide that I see you are surfing with glee.
My main reason to develop Drupal is still that it is an interesting thing to do. It enables people to do very interesting stuff. I don't ask these people to appreciate my work, but if they are set to disturb my productive process by sending false claims to this list, they'll need to face the heat or get out of the kitchen. Cheers, Gerhard
I dont want to get into this that much, but I can not stay in the background see this threat grow into an this-makes-no-sense threat. Op 20-apr-2006, om 17:01 heeft Gary (Lists) het volgende geschreven:
So far, as I've been subscribed to these lists for only a short time, what I've seen is a group of folks who believe they "are" Drupal. (And, of course, a confused guy -- me -- who doesn't understand how things like Documentation got left by the wayside.) If you are subscribed for such a short while, I advise you todo some investigation who your talking to before insulting people. Gerhard is a longtime drupal contributor and - I think the community agrees with me that - he is one of the most active and pasionated elites of the drupal community. In his time he developed *lots* of good things for drupal-core and drupal-contrib, which are from a very high standard when we look at code and usefullness.
I dare to say that he has the right to say to you, what he did. He proved his knowledge of code, and how things *should* work in a community. And yes, blaiming people that drupal isn't what they are after nor spreading negative feelings around for the way we choose to review and apply certain patches to core yes or no isn't something you should do when your around for such a short time. I advise you to think about this threat and decide if you are a community person yourself. We do things in a certain way, if you or me like it or not, that's the way the cookie crumbles here. In the past it proofed to be not a bad way, and unless you propose/introduce better ways of doing things you'll have to respect it. If you like it, or not. Now please, stop this threat by insulting people. This is a development list, and nothing else. Believe it or not people are unsubscribing for getting crap like this in their mailboxes, including me. We should discuss new features and discovered bugs here. Insulting people goes far better in a private mail then doing it on a public published mailinglist.. So, please stop and make up your thoughts.. Your sincerely, Stefan Nagtegaal.
On 20 Apr 2006, at 17:01, Gary (Lists) wrote:
I sincerely hope that people finally get this message.
One more thing, Mr. Drupal, before I unsub here (at your request)...
I think the message that you are communicating here is quite counter to any spirit of community, which is what you claim that you hope to foster (a community of open-source contributors.)
Only few people applaud or support the tone of Gerhard's statements. Gerhard's statements are often the source of personal flamewars ... just like now. These are not very productive and hurt the public face of the community. Personally, I find this quite disrespectful towards those (including myself) who try to foster a friendly and constructive atmosphere and who care about the public face of Drupal. Nonetheless, Gerhard is highly respected because of his good intentions, and the time and effort he contributes to Drupal. Obviously, he is high on my list. The point? Be smart and ignore the tone. We got used to it too. :) Linus Torvalds once said: ""Some people have told me they don't think a fat penguin really embodies the grace of Linux, which just tells me they have never seen an angry penguin charging at them in excess of 100mph. They'd be a lot more careful about what they say if they had." I think we can substitute "fat penguin" by "angry German" here. ;-) Just my 2 cents, -- Dries Buytaert :: http://www.buytaert.net/
On 20-Apr-06, at 1:16 PM, Dries Buytaert wrote:
I think we can substitute "fat penguin" by "angry German" here. ;-)
+1 - and that's about as deep as i'll be getting into any flamewar. -- James Walker :: http://walkah.net/ :: xmpp:walkah@walkah.net
On Thu, April 20, 2006 12:16 pm, Dries Buytaert said:
The point? Be smart and ignore the tone. We got used to it too. :)
Linus Torvalds once said: ""Some people have told me they don't think a fat penguin really embodies the grace of Linux, which just tells me they have never seen an angry penguin charging at them in excess of 100mph. They'd be a lot more careful about what they say if they had."
I think we can substitute "fat penguin" by "angry German" here. ;-)
Just my 2 cents,
Welcome back to herding cats, Dries. We missed you. :-) --Larry Garfield, who is also trying to avoid this flamewar
Dries Buytaert wrote: Preface: This is my last message in this thread.
On 20 Apr 2006, at 17:01, Gary (Lists) wrote:
I sincerely hope that people finally get this message.
One more thing, Mr. Drupal, before I unsub here (at your request)...
I think the message that you are communicating here is quite counter to any spirit of community, which is what you claim that you hope to foster (a community of open-source contributors.)
Only few people applaud or support the tone of Gerhard's statements.
Well, as long as the people who matter at least bear with me, I'm fine. And I know some of these people even share my views.
Gerhard's statements are often the source of personal flamewars ... just like now.
Sorry, but this is a) no flame war (if you believe that it is you haven't seen one, I am rather convinced you haven't participated in one ;-) (not enough messages in the thread and not enough participants to count as a flame war) and b) did Gary get the answer he deserved for what he posted to a _development_ list (see below).
These are not very productive and hurt the public face of the community.
I just want to state that your view and mine of who is actually part of the community quite apparently do not coincide. To me a member of the Drupal community is somebody who contributes in a useful way to the advancement of the Drupal project. There are many ways to do so, but bitching on the development about somebody's clients' needs is not one of them. Your criterion seems to be more relaxed which is fine with me, but I felt it neccessary to point out the difference.
Personally, I find this quite disrespectful towards those (including myself) who try to foster a friendly and constructive atmosphere and who care about the public face of Drupal.
I am sorry that I have to impede your effort like that, but I have a strong feeling about justice. And I feel it is very unjust that people like Gary (if he were the only one I would not have reacted like that) can come in, and disregard all the work we have been doing over the past years like he did. This personally offends me as a long time contributor to this wonderful project. And I think that I rather should speak out about this issue because the long time effects of letting go attitudes like his might be far more detrimental to the project than the occassional outburst. In short: I do not like the feeling to be taken advantage of and I think that many contributors will agree on this. I know that distributing Drupal under a liberal licence such as the GPL will inevitably lead to "only" users and this is fine with me. I don't send patches to the Linux kernel mailing list after all. But I don't bitch there about missing features either.
Nonetheless, Gerhard is highly respected because of his good intentions, and the time and effort he contributes to Drupal. Obviously, he is high on my list.
The point? Be smart and ignore the tone. We got used to it too. :)
And that from a guy who has been accused of being rude[1] more than once. :p
Linus Torvalds once said: ""Some people have told me they don't think a fat penguin really embodies the grace of Linux, which just tells me they have never seen an angry penguin charging at them in excess of 100mph. They'd be a lot more careful about what they say if they had."
I think we can substitute "fat penguin" by "angry German" here. ;-)
Have you ever seen a penguin swim under water? Such elegance! Cheers, Gerhard [1] quite wrongly, but not by me.
"Gerhard Killesreiter" wrote:
Then do me the favour and leave. Now.
I am really fed up with people making money from Drupal and not contributing back but by whining. Get lost. All of you. Now.
Hey, no problem. -- Gary
On 20 Apr 2006, at 03:11, Khalid B wrote:
It is unlikely that bug fixes against 4.6.x would be accepted, simply because we try to restrict fixes to stable releases to secruity fixes only.
This information is incorrect. The Drupal 4.6 branch is being maintained and fixes are being committed. (See the release announcements for details.) We are, however, slightly more conservative with patches that fix bugs in Drupal 4.6. Given that your patches are tested and supported by a number of people, they can make it into the next Drupal 4.6 maintenance release. So best to submit your patch to the issue tracker and to rally up some people to thumb it up. -- Dries Buytaert :: http://www.buytaert.net/
"Dries Buytaert" wrote:
So best to submit your patch to the issue tracker and to rally up some people to thumb it up.
Respectfully, this sounds likek a problem. If a patch fixes a bug, and someone has taken the time to spot the bug, fix the bug, and make a patch, then why do they also then need to engage in personality politics to get the fix applied? This statement reads a bit like "Well, even you fix a bug, we may not apply the fix if we don't like you." That's an odd method of development. But it surely explains some things. Or did I mis-read? Or did you mis-write? -- Gary
If a patch fixes a bug, and someone has taken the time to spot the bug, fix the bug, and make a patch, then why do they also then need to engage in personality politics to get the fix applied?
Because, ultimately, it takes effort to convince people that a) it's actually a bug, b) your solution is correct, and better than any other possibility, and c) to get people to come look at it and review it. -- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ O'Reilly Author, Weblog, Cook: http://www.oreillynet.com/pub/au/779 icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus
Gary (Lists) wrote:
"Dries Buytaert" wrote:
So best to submit your patch to the issue tracker and to rally up some people to thumb it up.
Respectfully, this sounds likek a problem.
If a patch fixes a bug, and someone has taken the time to spot the bug, fix the bug, and make a patch, then why do they also then need to engage in personality politics to get the fix applied?
This statement reads a bit like "Well, even you fix a bug, we may not apply the fix if we don't like you."
That's an odd method of development. But it surely explains some things.
It's primarily about signal::noise ratio. There is a lot for people to look at, and a small number of people who can actually commit fixes to these bugs. They strive to make sure that the fixes they commit are good, solid, strong fixes. One person's opinion is not necessary the right course of action, and it takes a lot less work on the committer to say "This is good" if there are several people who are known and trusted behind the fix, than one person who is behind it. It's not about playing politics, so much as it's about ensuring that the committed patches are right.
Gary (Lists) wrote:
If a patch fixes a bug, and someone has taken the time to spot the bug, fix the bug, and make a patch, then why do they also then need to
engage in personality politics to get the fix applied?
This statement reads a bit like "Well, even you fix a bug, we may not
apply the fix if we don't like you."
I've never seen that problem, to be honest. There are good patches that have been shot down, but they were almost invariably written by people who were active and respected members of the community: they were rejected for core not because of personality politics, but because there was dissent among core Drupal contributors about the necessity and usefulness of the patches. A number of these have gone on to become contrib modules (See the prepopulate.module). Others are still being maintained and lobbied (see the trashbin patch). This is frustrating when it's MY patch I'm lobbying for, but tremendously helpful when I'm putting a new site together and don't have to work around cruft from everyone ELSE'S pet features. It's not perfect, but it's a balance I'm happy with these days. The *really* simple stuff tends to get committed quickly as long as it's an actual bug and isn't just masking a more fundamental problem. One thing that I've noticed about the Drupal community is that there is a VERY high value put on a clean and cruft-free core for contrib modules to build on. There is also a STRONG community aversion to 'band-aid fixes.' In other words, if there's a fundamental problem in a particular module or subsystem, it's often easy to slap in a workaround. MANY of the patches submitted by those less familiar with the Drupal architecture are like that. Often, these patches are shelved in favor of solutions that take longer to complete but solve the underlying problems. --Jeff
On 20 Apr 2006, at 15:13, Gary (Lists) wrote:
If a patch fixes a bug, and someone has taken the time to spot the bug, fix the bug, and make a patch, then why do they also then need to engage in personality politics to get the fix applied?
This statement reads a bit like "Well, even you fix a bug, we may not apply the fix if we don't like you."
That's an odd method of development. But it surely explains some things.
Maybe my initial wording was confusing but it certainly is not politics. It is quality assurance. If you submit a patch, the patch needs to be reviewed and tested before it can get committed. The process of reviewing and testing patches is distributed amongst (mostly) volunteer contributors. By uploading your patch to the patch queue (or the issue tracker), reviewers will be able to find your patch. It's just the process we put in place to get bugs fixed. I was inviting you to use this process. -- Dries Buytaert :: http://www.buytaert.net/
On 4/20/06, Dries Buytaert <dries.buytaert@gmail.com> wrote:
On 20 Apr 2006, at 03:11, Khalid B wrote:
It is unlikely that bug fixes against 4.6.x would be accepted, simply because we try to restrict fixes to stable releases to secruity fixes only.
This information is incorrect.
The Drupal 4.6 branch is being maintained and fixes are being committed. (See the release announcements for details.) We are, however, slightly more conservative with patches that fix bugs in Drupal 4.6. Given that your patches are tested and supported by a number of people, they can make it into the next Drupal 4.6 maintenance release.
So best to submit your patch to the issue tracker and to rally up some people to thumb it up.
I was merely reiterating our historical practice to date, which is basically what I said. See for example Dries' comment and closing an issue as won't fix. http://drupal.org/node/43712#comment-68805 However, this is in the past, and things have changed now. We have two more committers to core, and people designated for specific branches. This means we have more capacity to maintain the previous branch than we had before. So, if this is a change in policy that we should consider going forward, then that is a good thing to have. We improve things as we move forward including policies and processes.
First, to submit a patch: http://drupal.org/node/22568
I have a patch that fixes this issue reasonably. Please let me know how I should go about contributing it. Perhaps I could post the patch somewhere - either on this list or on one of the forums on drupal.org - and then one of the contributors can propagate it to the source code.
I'm sure nobody would mind you posting your fix to the list. Though that's not technically the way to submit a bug fix, it's a nice thing to offer those of us who'll not likely benefit from your work lest you apply it to 4.7 and it's accepted. Just send us an URL with your fix and tell us about it. Since Drupal's in 4.7 mode right now, your fix may get slotted for limbo land. But, if you can hone your fix for 4.7, that would be nice. -- Jason A. Nunnelley ---------------------------------------- http://www.jasonn.com/
JasonN wrote:
First, to submit a patch: http://drupal.org/node/22568
I have a patch that fixes this issue reasonably. Please let me know how I should go about contributing it. Perhaps I could post the patch somewhere - either on this list or on one of the forums on drupal.org - and then one of the contributors can propagate it to the source code.
I'm sure nobody would mind you posting your fix to the list. Though that's not technically the way to submit a bug fix, it's a nice thing to offer those of us who'll not likely benefit from your work lest you apply it to 4.7 and it's accepted.
Just send us an URL with your fix and tell us about it. Since Drupal's in 4.7 mode right now, your fix may get slotted for limbo land. But, if you can hone your fix for 4.7, that would be nice.
Unfortunately, I do not have a externally available URL for demonstrating the fix. I will see if I can try out Drupal 4.7.x and verify if the bug exists there also. Thanks, Nimish
--
Jason A. Nunnelley ---------------------------------------- http://www.jasonn.com/
Unfortunately, I do not have a externally available URL for demonstrating the fix.
You do not have to demonstrate the fix. You have to provide a) a description of the problem b) a patch that has the fix. These are best done via opening an issue on drupal.org against the appropriate project(s). This way they will be tracked and have the best chance of gaining visibility and being acted upon as well as having followups by others (reports on success to reproduce the issue, people who had it fixed, improvements to your fix, ...etc.)
I will see if I can try out Drupal 4.7.x and verify if the bug exists there also.
If you find it there, please be quick to provide a fix. It has a very good chance for making it with the first 4.7 release.
I have opened an issue on Drupal.org and attached the patch to it. http://drupal.org/node/60894 The patch for flexinode is actually different. It had to do with an empty where clause being appended to the query in one of the contrib files. I misspoke earlier when I said that this module also suffers from the PostgreSQL problem. I have created an issue for the flexinode problem and attached a patch as well. http://drupal.org/node/60901 Thanks to all for directing me to the right place. - Nimish Khalid B wrote:
Unfortunately, I do not have a externally available URL for demonstrating the fix.
You do not have to demonstrate the fix. You have to provide a) a description of the problem b) a patch that has the fix.
These are best done via opening an issue on drupal.org against the appropriate project(s).
This way they will be tracked and have the best chance of gaining visibility and being acted upon as well as having followups by others (reports on success to reproduce the issue, people who had it fixed, improvements to your fix, ...etc.)
I will see if I can try out Drupal 4.7.x and verify if the bug exists there also.
If you find it there, please be quick to provide a fix. It has a very good chance for making it with the first 4.7 release.
participants (15)
-
Boris Mann -
Dries Buytaert -
Earl Miles -
Gary (Lists) -
Gerhard Killesreiter -
James Walker -
JasonN -
Jeff Eaton -
Khalid B -
Larry Garfield -
Morbus Iff -
Nic Ivy -
Nimish Pachapurkar -
piotr＠mallorn.ii.uj.edu.pl -
Stefan Nagtegaal