If I wanted to check out all the contributions, how much disk space and bandwidth would I be looking at? Or... is there any other way to grep through contrib modules? I want to know how many use the forms API's #post_process feature to evaluate the impact of a potential patch. ...R.
I want to know how many use the forms API's #post_process feature to evaluate the impact of a potential patch.
Noone even knows that exists :) I am about to rename it because it's damned confusing -- new is #after_build. If you want to merge the rename and param removal patch into one, be my guest. Regards NK
On 11/16/05 3:17 AM, Karoly Negyesi wrote:
I want to know how many use the forms API's #post_process feature to evaluate the impact of a potential patch.
And already I am wrong: image does use it...
yeah it does, and can you please outline why exactly it needs to change? i don't think just renaming for the heck of it at this point makes much sense. that's the kind of stuff that should have been done *before* formapi hit core, imnsho. -- James Walker :: http://walkah.net/ :: xmpp:walkah@walkah.net
On Wed, 16 Nov 2005 14:59:24 +0100, James Walker <walkah@walkah.net> wrote:
On 11/16/05 3:17 AM, Karoly Negyesi wrote:
I want to know how many use the forms API's #post_process feature to evaluate the impact of a potential patch. And already I am wrong: image does use it...
yeah it does, and can you please outline why exactly it needs to change? i don't think just renaming for the heck of it at this point makes much sense. that's the kind of stuff that should have been done *before* formapi hit core, imnsho.
James, for heaven's sake, where were you when we ported core? Have you said that 'stop, this will confuse users'? We made an error by naming that so, and we correct it before spreads. It confuses people because here post refers to "after" as in "after the build is done" and not $_POST. Why is it so bad to adjust it after it hit core? If it wouldn't do you think anyone would have tested a four houndred kilobyte patch? Regards NK
Richard Archer wrote:
If I wanted to check out all the contributions, how much disk space and bandwidth would I be looking at?
killes@theo-dhcp-42:~/checkouts/contributions$ du -ks 131136
Or... is there any other way to grep through contrib modules?
Not really.
I want to know how many use the forms API's #post_process feature to evaluate the impact of a potential patch.
Not too many yet; image/image.module: $form['thumbnail']['#post_process'] = 'image_form_add_thumbnail'; project/comment.inc: $form['#post_process'] = 'node_form_add_preview'; Also, we don't care for the number of times something needs to be changed in contrib. Cheers, Gerhard
participants (4)
-
Gerhard Killesreiter -
James Walker -
Karoly Negyesi -
Richard Archer