Code review for most downloaded modules
John may have been half joking, but Morbus really did a good job reviewing the code for LinksDB. Here is an idea, it may not fly because it is "grunt work" and resource intensive, but how about we get a few people to do what Morbus did to the top 10 (or 50 or whatever) downloaded modules? This can be a step towards the top tier/certified/gold modules? On 8/2/06, John VanDyk <jvandyk@iastate.edu> wrote:
Wow, Morbus. Will you go through my modules, too, please?
Sounds good, as long as whoever does the review is a little more sensitive towards the feelings of the developer that moby was. Just going through the code and slating it to hell and back doesn't inspire the coder to do a better job. That said, because I am nice, and I aim to please, I am going through my code and using his suggestions. If I were anyone else, the reply 'f**k you moby' may come back. M On 2 Aug 2006, at 14:42, Khalid B wrote:
John may have been half joking, but Morbus really did a good job reviewing the code for LinksDB.
Here is an idea, it may not fly because it is "grunt work" and resource intensive, but how about we get a few people to do what Morbus did to the top 10 (or 50 or whatever) downloaded modules?
This can be a step towards the top tier/certified/gold modules?
On 8/2/06, John VanDyk <jvandyk@iastate.edu> wrote:
Wow, Morbus. Will you go through my modules, too, please?
Scanned by MailDefender - managed email security from intY - www.maildefender.net
Information in this electronic mail is confidential and may be legally privileged. It is intended solely for the addressee. Access to this mail by anyone else is unauthorised. If you are not the intended recipient any use, disclosure, copying or distribution of this message is prohibited and may be unlawful. When addressed to our customers, any information contained in this message is subject to intY's Terms & Conditions. Please rely on your own virus scanning and procedures with regard to any attachments to this message. Scanned by MailDefender - managed email security from intY - www.maildefender.net
Khalid B wrote:
John may have been half joking, but Morbus really did a good job reviewing the code for LinksDB.
Here is an idea, it may not fly because it is "grunt work" and resource intensive, but how about we get a few people to do what Morbus did to the top 10 (or 50 or whatever) downloaded modules?
Excellent reason to post the download stats for July: drupal-4.7.2 30077 drupal-4.6.8 6280 image-4.7.0 4703 tinymce-4.7.0 4370 4.7-installing.mov 3549 4.7-whats-new.mov 3513 event-4.7.0 2518 ecommerce-4.7.0 2330 gallery-4.7.0 2233 acidfree-4.7.0 2161 friendselectric-4.7.0 2086 views-4.7.0 1999 meta-4.7.0 1880 flatforum-4.7.0 1855 cck-4.7.0 1784 front-4.7.0 1770 img_assist-4.7.0 1676 internet_services-4.7.0 1626 adsense-4.7.0 1591 antique_modern-4.7.0 1584 flexinode-4.7.0 1534 fancy-4.7.0 1505 spreadfirefox-4.7.0 1463 category-4.7.0 1430 gsitemap-4.7.0 1408 fern-4.7.0 1354 webform-4.7.0 1318 box_grey-4.7.0 1294 B7-4.7.0 1291 niftyCorners-4.7.0 1281 es-4.7.0 1272 contented7-4.7.0 1256 taxonomy_access-4.7.0 1248 views-cvs 1243 print-4.7.0 1232 4.7-upgrading.mov 1226 pathauto-4.7.0 1221 og-4.7.0 1217 nice_menus-4.7.0 1204 user_search-4.6.0 1201 controlpanel-4.7.0 1188 chatbox-4.7.0 1172 internet_jobs-4.7.0 1129 article-4.7.0 1115 emailpage-4.7.0 1111 audio-4.7.0 1104 channel_nine-4.7.0 1103 google_analytics-4.7.0 1087 captcha-4.7.0 1054 burnt-4.7.0 1051 feedback-4.7.0 1041 k2-4.7.0 1036 i18n-4.7.0 1034 bbcode-4.7.0 1007
On Aug 2, 2006, at 6:56 AM, Gerhard Killesreiter wrote:
Khalid B wrote:
John may have been half joking, but Morbus really did a good job reviewing the code for LinksDB. Here is an idea, it may not fly because it is "grunt work" and resource intensive, but how about we get a few people to do what Morbus did to the top 10 (or 50 or whatever) downloaded modules?
How is this generated? I thinking that perhaps http://drupal.org/ handbook/modules should have a link to a page showing this months most downloaded modules. Kieran
Excellent reason to post the download stats for July:
drupal-4.7.2 30077 drupal-4.6.8 6280 image-4.7.0 4703 tinymce-4.7.0 4370 4.7-installing.mov 3549 4.7-whats-new.mov 3513 event-4.7.0 2518 ecommerce-4.7.0 2330 gallery-4.7.0 2233 acidfree-4.7.0 2161 friendselectric-4.7.0 2086 views-4.7.0 1999 meta-4.7.0 1880 flatforum-4.7.0 1855 cck-4.7.0 1784 front-4.7.0 1770 img_assist-4.7.0 1676 internet_services-4.7.0 1626 adsense-4.7.0 1591 antique_modern-4.7.0 1584 flexinode-4.7.0 1534 fancy-4.7.0 1505 spreadfirefox-4.7.0 1463 category-4.7.0 1430 gsitemap-4.7.0 1408 fern-4.7.0 1354 webform-4.7.0 1318 box_grey-4.7.0 1294 B7-4.7.0 1291 niftyCorners-4.7.0 1281 es-4.7.0 1272 contented7-4.7.0 1256 taxonomy_access-4.7.0 1248 views-cvs 1243 print-4.7.0 1232 4.7-upgrading.mov 1226 pathauto-4.7.0 1221 og-4.7.0 1217 nice_menus-4.7.0 1204 user_search-4.6.0 1201 controlpanel-4.7.0 1188 chatbox-4.7.0 1172 internet_jobs-4.7.0 1129 article-4.7.0 1115 emailpage-4.7.0 1111 audio-4.7.0 1104 channel_nine-4.7.0 1103 google_analytics-4.7.0 1087 captcha-4.7.0 1054 burnt-4.7.0 1051 feedback-4.7.0 1041 k2-4.7.0 1036 i18n-4.7.0 1034 bbcode-4.7.0 1007
Op woensdag 2 augustus 2006 15:42, schreef Khalid B:
Here is an idea, it may not fly because it is "grunt work" and resource intensive, but how about we get a few people to do what Morbus did to the top 10 (or 50 or whatever) downloaded modules?
It is not exactly fun. Nor rewarding. Turning this into issues is even less fun, especially since the topX modules all seem to have rather large issue queues with lots of rather pressing issues. Dries once made some automated scripts which could be found under your project page. Where did they go? Using these reports is a first big step. I doubt half of the developers were aware of these code reports, let alone looked at it on a regular basis! I -personally- was not even aware that they were gone! So much for good intentions :)
This can be a step towards the top tier/certified/gold modules?
In railfrog we have this policy that nothing gets into the stable branch without unit-tests. (Same in the blog system typo[1]) Without passing these tests, but also without creating these tests. This might sound like an awfull high barrier, in fact it /is/ an awfull high barrier. But AFAIK it is a required first step (demanding tests and passing tests) when you want to offer Real Quality. So, some maths: A: we have a unit test engine. But I guess, just like me, most of you thought: "yea, I should really have a look at them soon". Enforcing such tests for the top tier/certified/gold modules sounds like a good idea to me. It might get some of us/me to actually write them :) B: we know the top X modules, by pingback, download stats and more. C: Dries has or had some automated "thingies" to find common mistakes. Not sure if its possible to tie this to project module again, though. B + C makes a good list of todos for the top tier/certified/gold modules. A + C makes a nice todo for us to get some quality control in. A + B + C makes Drupal look a lot more professional to the outside world. Bèr [1] http://www.typosphere.org/trac/wiki/PatchingGuide
On Wed, 02 Aug 2006 16:17:03 +0200, Bèr Kessels <ber@webschuur.com> wrote:
Op woensdag 2 augustus 2006 15:42, schreef Khalid B:
Here is an idea, it may not fly because it is "grunt work" and resource intensive, but how about we get a few people to do what Morbus did to the top 10 (or 50 or whatever) downloaded modules?
It is not exactly fun. Nor rewarding. Turning this into issues is even less fun, especially since the topX modules all seem to have rather large issue queues with lots of rather pressing issues.
Dries once made some automated scripts which could be found under your project page. Where did they go?
They are still in contributions/tricks/code-checker/ . I've slightly modified it to run on multiple directories and used it on all contributed modules (cvs). If you want this file (910 kiB) please let me know. Not sure how big attachments to the list are handled. Kind regards, Heine
Bèr Kessels wrote:
Op woensdag 2 augustus 2006 15:42, schreef Khalid B:
Here is an idea, it may not fly because it is "grunt work" and resource intensive, but how about we get a few people to do what Morbus did to the top 10 (or 50 or whatever) downloaded modules?
It is not exactly fun. Nor rewarding. Turning this into issues is even less fun, especially since the topX modules all seem to have rather large issue queues with lots of rather pressing issues.
Dries once made some automated scripts which could be found under your project page. Where did they go?
The codechecker status is still created, but no longer linked to: e.g.: http://ftp.osuosl.org/pub/drupal/files/projects/event.status
Using these reports is a first big step. I doubt half of the developers were aware of these code reports, let alone looked at it on a regular basis! I -personally- was not even aware that they were gone! So much for good intentions :)
The script is in CVS and all good attentions cen be directed there to improve it. Derek will sure find a way to restore the link. Cheers, Gerhard
participants (6)
-
Bèr Kessels -
Gerhard Killesreiter -
Heine Deelstra -
Khalid B -
Kieran Lal -
Matthew Jenkins