While base_path() does many a good thing, it also presents a couple of obstacles that could use further discussion. - Enabling or disabling clean_urls on a site with content will break hand-rolled links. For example on my staging server clean_urls are disabled but they're enabled in production. If I continue to do that, my links will break. - Moving a Drupal site from one subdirectory to another or from a subdirectory up to a root folder will break links if the site is using clean_urls. How should we solve these problems? A couple of ideas. Let's pick one. 1) Provide a link updater script in the scripts/ folder 2) Add some sort of 'fix my links' button via the admin interface 3) Hook a URL fixing script into the clean_url form toggle so it runs after the setting has changed. 4) Make a link-updater contrib module to point users to. I'm in the camp of #4 since I see this as a rarely used interface option. Oh, and I'm also volunteering my time to write the mod. Matt Westgate | www.lullabot.com
I addition, I vote for and easy way to re-add the BASE tag. I for one, had no problems with BASE, now that it is removed by default, I would like to add it back, to my themes (choice is good, we now have a choice!). Patch here: http://drupal.org/node/51612 Bèr -- Sympal draait nu voor het grootste deel al op 4.7: http://help.sympal.nl/sympal_draait_nu_voor_het_grootste_deel_al_op_4_7
Bèr Kessels wrote:
I addition, I vote for and easy way to re-add the BASE tag. I for one, had no problems with BASE, now that it is removed by default, I would like to add it back, to my themes (choice is good, we now have a choice!). Patch here: http://drupal.org/node/51612
Bèr
please don't hijack threads. we already have problem on this list with focused discussions. #4 sounds good to me.
Op dinsdag 7 maart 2006 15:42, schreef Moshe Weitzman:
please don't hijack threads. we already have problem on this list with focused discussions.
My addition is not off topic nor unfocused. Its a solution #5. A solution that already works and can perfectly co-exist with any of the other four. Or am I missing something here? Bèr -- [ End user Drupal services and hosting | Sympal.nl ]
I like 4 combined with 3. Once 4 exists, 3 should be trivial to implement. Making it visible on screen, means that it is more likely to get done. Yes, people who have not installed the contrib will get nasty message, but that is better than slowly getting broken link reports.
-----Original Message----- From: development-bounces@drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Matt Westgate Sent: Tuesday, March 07, 2006 12:09 AM To: development@drupal.org Subject: [development] a couple things to discuss about base_path()
While base_path() does many a good thing, it also presents a couple of obstacles that could use further discussion.
- Enabling or disabling clean_urls on a site with content will break hand-rolled links. For example on my staging server clean_urls are disabled but they're enabled in production. If I continue to do that, my links will break.
- Moving a Drupal site from one subdirectory to another or from a subdirectory up to a root folder will break links if the site is using clean_urls.
How should we solve these problems? A couple of ideas. Let's pick one.
1) Provide a link updater script in the scripts/ folder
2) Add some sort of 'fix my links' button via the admin interface
3) Hook a URL fixing script into the clean_url form toggle so it runs after the setting has changed.
4) Make a link-updater contrib module to point users to.
I'm in the camp of #4 since I see this as a rarely used interface option. Oh, and I'm also volunteering my time to write the mod.
Matt Westgate | www.lullabot.com
In http://drupal.org/node/13148#comment-78766 I mentioned that base seems to work fine. I like the "fix my links" approach, since it can be done whenever. This could evolve into a referenetial link checker (makes sure that the link exists). This can be #4 (a contrib module), and can have more features as time goes by. Morbus, where are you?
participants (5)
-
Bèr Kessels -
Khalid B -
Matt Westgate -
Moshe Weitzman -
Walt Daniels